8000 TST Extend tests for `scipy.sparse.*array` in `sklearn/tests/test_kernel_ridge.py` by kianelbo · Pull Request #27270 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Extend tests for scipy.sparse.*array in sklearn/tests/test_kernel_ridge.py #27270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2023
Merged

TST Extend tests for scipy.sparse.*array in sklearn/tests/test_kernel_ridge.py #27270

merged 2 commits into from
Sep 11, 2023

Conversation

kianelbo
Copy link
Contributor
@kianelbo kianelbo commented Sep 2, 2023

Reference Issues/PRs

Towards #27090

What does this implement/fix? Explain your changes.

Use scipy.sparse.*array in sklearn/tests/test_kernel_ridge.py

@github-actions
Copy link
github-actions bot commented Sep 2, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a3da3e2. Link to the linter CI: here

Charlie-XIAO
Charlie-XIAO reviewed Sep 2, 2023
View reviewed changes
@kianelbo kianelbo force-pushed the csr-container-test-kernel-ridge branch from 0113623 to a3da3e2 Compare September 2, 2023 18:04
@jjerphan jjerphan mentioned this pull request Sep 3, 2023
Closed
OmarManzoor
OmarManzoor approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor
@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kianelbo

@glemaitre glemaitre requested review from glemaitre and removed request for Charlie-XIAO September 11, 2023 18:02
glemaitre
glemaitre approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kianelbo

@glemaitre glemaitre merged commit 611cffe into scikit-learn:main Sep 11, 2023
@kianelbo kianelbo deleted the csr-container-test-kernel-ridge branch September 12, 2023 10:04
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@kianelbo @REDVM
TST Extend tests for scipy.sparse.*array in `sklearn/tests/test_ker…
261cc48 
…nel_ridge.py` (scikit-learn#27270)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charlie-XIAO Charlie-XIAO Charlie-XIAO left review comments

@glemaitre glemaitre glemaitre approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kianelbo @glemaitre @OmarManzoor @Charlie-XIAO
0