Remove validation from __init__ and set_params from SGDOneClassSVM #21824
Conversation
|
@glemaitre Could you please guide how to proceed in the following issue? If I let alpha stay in init then it will fail but if I move alpha assignment to _validation_params it gives me a error of setting class attribute alpha is not acceptable. |
|
This will likely be complex to fix because of the class hierarchy that implies shared code while enforcing the same name for a reparametrized hyper-parameter... +1 the backward compat handling that will be tricky to get right. @MrinalTyagi let me suggest to try to tackle another estimator. Getting this one right will open a can of worms. |
|
@ogrisel Sure. I am willing to contributions to any type of issue or feature addition so you can definitely provide me another estimator as well as other issues if you feel right as I have just started working on open source and wanna continue it. |
|
Hi @MrinalTyagi and @ogrisel, @iofall and I started working on this last week not realizing that a solution had already been drafted. We did the following and it seemed to pass all of the test required:
Let me know what you think! |
Test like the build test or the individual test for this class that runs using |
|
@arisayosh I am not sure I understand the details of your plan because when you speak of |
Hi @MrinalTyagi, we tested We've opened a concurrent PR here for these changes --> #21944. The |
|
Done in #24433 |
Reference Issues/PRs
Address: #21406
What does this implement/fix? Explain your changes.
Add type check of alpha in _validation in SGDOneClassSVM class
Any other comments?
Support from someone in case of error in merging will be highly appreciable.