ENH Remove validation from __init__ for SGDOneClassSVM
#24433
Conversation
8c8d629 to
44e1d8b
Compare
|
What exactly does scikit-learn/sklearn/tests/test_common.py Lines 434 to 463 in 53acd0f SGDOneClassSVM the only estimator that is being checked? I was expecting this list to contain all estimators, except for those that do things like validate parameters. So I am a bit puzzled what happens here.
However based on what the code looks like ... should we remove |
Co-authored-by: iofall <50991099+iofall@users.noreply.github.com> Co-authored-by: arisayosh <15692997+arisayosh@users.noreply.github.com>
44e1d8b to
72c8061
Compare
it's the opposite actually. See the parametrization
It just checks that no error is raised (hence that no validation is done) when passing wrong params to init. All validations should happen in fit because meta estimators like GridSearchCV need to set params on already instanciated estimators |
Need to get my 👓 checked, the name of the variable made me think that "this is the initial list to consider, now lets filter it" for this list comprehension ... didn't see the Removed |
Co-authored-by: iofall 50991099+iofall@users.noreply.github.com
Co-authored-by: arisayosh 15692997+arisayosh@users.noreply.github.com
Continuation of #21944 which contributes to #21406