8000 Remove validation from `__init__` and `set_params` · Issue #21406 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content
Remove validation from __init__ and set_params #21406
@thomasjpfan

Description

@thomasjpfan

This issue is reserved for the Data Umbrella Africa & Middle East Sprint on October 23, 2021 as a good first issue. For non-sprint contributors, please wait till October 30, 2021 to work on this issue.

Follow up to #16945

  1. Make sure you have the development dependencies and documentation dependencies installed.
  2. Pick an from the list below and leave a comment saying you are going to work on it. This way we can keep track of what everyone is working on.
  3. Remove the estimator(s) from:

VALIDATE_ESTIMATOR_INIT = [

  1. Run the test for checking for no validation, which should fail:
pytest sklearn/tests/test_common.py::test_estimators_do_not_raise_errors_in_init_or_set_params
  1. Update the codebase so the above test passes.
  2. Open a Pull Request with an opening message Addresses #21406. Note that each item should be submitted in a separate Pull Request.
  3. Include the function name in the title of the pull request. For example: "ENH Removes validation in __init__ for _______".

Estimators on the same line should be fixed together since they share a parent class.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Meta-issueGeneral issue associated to an identified list of tasksModerateAnything that requires some knowledge of conventions and best practicesSprint

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0