Fix test_parity xfail for sigmoid #134253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134253
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0669c68 with merge base b417e32 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
amjames
approved these changes
Aug 26, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 26, 2024
Pull Request resolved: #134344 Approved by: https://github.com/amjames, https://github.com/janeyx99 ghstack dependencies: #134253
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 26, 2024
Previously, error messages were expected to be string equivalent to error messages thrown by the ref function. This check fails for dozens of torch functions, and doesn't appear to add much value for the end user. This commit removes this check. Pull Request resolved: #134251 Approved by: https://github.com/amjames, https://github.com/janeyx99 ghstack dependencies: #134253, #134344
pytorch-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Pull Request resolved: #134253 Approved by: https://github.com/amjames, https://github.com/janeyx99
pytorch-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Pull Request resolved: #134344 Approved by: https://github.com/amjames, https://github.com/janeyx99 ghstack dependencies: #134253
pytorch-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Previously, error messages were expected to be string equivalent to error messages thrown by the ref function. This check fails for dozens of torch functions, and doesn't appear to add much value for the end user. This commit removes this check. Pull Request resolved: #134251 Approved by: https://github.com/amjames, https://github.com/janeyx99 ghstack dependencies: #134253, #134344
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: pytorch#134253 Approved by: https://github.com/amjames, https://github.com/janeyx99
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: pytorch#134344 Approved by: https://github.com/amjames, https://github.com/janeyx99 ghstack dependencies: pytorch#134253
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…h#134251) Previously, error messages were expected to be string equivalent to error messages thrown by the ref function. This check fails for dozens of torch functions, and doesn't appear to add much value for the end user. This commit removes this check. Pull Request resolved: pytorch#134251 Approved by: https://github.com/amjames, https://github.com/janeyx99 ghstack dependencies: pytorch#134253, pytorch#134344
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 26, 2024
8000
Pull Request resolved: pytorch#134344 Approved by: https://github.com/amjames, https://github.com/janeyx99 ghstack dependencies: pytorch#134253
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 26, 2024
…h#134251) Previously, error messages were expected to be string equivalent to error messages thrown by the ref function. This check fails for dozens of torch functions, and doesn't appear to add much value for the end user. This commit removes this check. Pull Request resolved: pytorch#134251 Approved by: https://github.com/amjames, https://github.com/janeyx99 ghstack dependencies: pytorch#134253, pytorch#134344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @crcrpar @mcarilli @janeyx99