Fix test_parity xfail for sigmoid

benjaminglass1 · benjaminglass1 · commit 9afd6c770a53 · 2024-08-22T18:05:38.000Z
ghstack-source-id: 7090566 Pull Request resolved: #134253
diff --git a/aten/src/ATen/native/cuda/ForeachUnaryOp.cu b/aten/src/ATen/native/cuda/ForeachUnaryOp.cu
@@ -304,7 +304,7 @@ struct Sign {
   }
 };
 
-OP_CUSTOM_FUNCTOR(floating_half_bfloat16, sigmoid, Sigmoid)
+OP_CUSTOM_FUNCTOR(floating_complex_half_bfloat16, sigmoid, Sigmoid)
 OP_CUSTOM_FUNCTOR(floating_half_bfloat16, round, Round)
 OP_CUSTOM_FUNCTOR(floating_half_bfloat16, frac, Trunc)
 OP_CUSTOM_FUNCTOR(floating_complex_half_bfloat16, reciprocal, Reciprocal)
diff --git a/torch/testing/_internal/common_methods_invocations.py b/torch/testing/_internal/common_methods_invocations.py
@@ -10578,16 +10578,6 @@ def __call__(self, opinfo, device, dtype, requires_grad, **kwargs):
                 device_type="cuda",
                 dtypes=complex_types(),
             ),
-            # FIXME: the fast path for CUDA sigmoid is either unimplemented or
-            # inaccessible.  The slow path exists, so this is probably an error?
-            DecorateInfo(
-                unittest.expectedFailure,
-                "TestForeach",
-                "test_parity",
-                device_type="cuda",
-                dtypes=complex_types(),
-                active_if=lambda kwargs: not kwargs.get("noncontiguous", False),
-            ),
             DecorateInfo(
                 unittest.expectedFailure,
                 "TestForeach",

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ struct Sign {`
`304`	`304`	`}`
`305`	`305`	`};`
`306`	`306`
`307`		`-OP_CUSTOM_FUNCTOR(floating_half_bfloat16, sigmoid, Sigmoid)`
	`307`	`+OP_CUSTOM_FUNCTOR(floating_complex_half_bfloat16, sigmoid, Sigmoid)`
`308`	`308`	`OP_CUSTOM_FUNCTOR(floating_half_bfloat16, round, Round)`
`309`	`309`	`OP_CUSTOM_FUNCTOR(floating_half_bfloat16, frac, Trunc)`
`310`	`310`	`OP_CUSTOM_FUNCTOR(floating_complex_half_bfloat16, reciprocal, Reciprocal)`