8000 Remove unnecessary test skip by benjaminglass1 · Pull Request #134250 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Remove unnecessary test skip #134250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove unnecessary test skip #134250

wants to merge 2 commits into from

Conversation

benjaminglass1
Copy link
Collaborator
@benjaminglass1 benjaminglass1 commented Aug 22, 2024 •
edited
Loading

@benjaminglass1
Update
9d1fb38 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Aug 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134250

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0d5591b with merge base f8fbfe5 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Aug 22, 2024
This was referenced Aug 22, 2024
Closed
Closed
Closed
amjames
amjames approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator
@amjames amjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always love a purely negative PR. Nice.

@amjames amjames marked this pull request as ready for review August 23, 2024 15:58
@amjames amjames requested a review from mruberry as a code owner August 23, 2024 15:58
@amjames amjames added the module: mta Issues related to multi-tensor apply kernels and foreach functions label Aug 23, 2024
@amjames amjames requested a review from janeyx99 August 23, 2024 16:01
janeyx99
janeyx99 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor
@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah not sure how it got fixed, do u know?

@benjaminglass1
Copy link
Collaborator Author

@janeyx99 I honestly don't know; I just noticed it and figured I should test if it was still relevant while working in the area.

@benjaminglass1 benjaminglass1 mentioned this pull request Aug 23, 2024
Closed
@amjames
Copy link
Collaborator
amjames commented Aug 23, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 23, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@benjaminglass1
Update
0d5591b 
[ghstack-poisoned]
@amjames
Copy link
Collaborator
amjames commented Aug 23, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@amjames
Copy link
Collaborator
amjames commented Aug 26, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

enter-ctrl9 pushed a commit to enter-ctrl9/pytorch11 that referenced this pull request Sep 15, 2024
@benjaminglass1
Remove unnecessary test skip
1349b19 
ghstack-source-id: 641e9f6
Pull Request resolved: pytorch/pytorch#134250
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@benjaminglass1 @Chao1Han
Remove unnecessary test skip (pytorch#134250)
127228a 
Pull Request resolved: pytorch#134250
Approved by: https://github.com/amjames, https://github.com/janeyx99
@github-actions github-actions bot deleted the gh/benjaminglass1/1/head branch October 1, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amjames amjames amjames approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

@mruberry mruberry Awaiting requested review from mruberry

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: mta Issues related to multi-tensor apply kernels and foreach functions open source release notes: python_frontend python frontend release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benjaminglass1 @amjames @pytorchmergebot @janeyx99 @pytorchbot
0