[BE][Easy] replace import pathlib with from pathlib import Path
#129426
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129426
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 6 Unrelated FailuresAs of commit e1f7982 with merge base 2effbcf ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
In torch/onnx we prefer importing modules only: https://google.github.io/styleguide/pyguide.html#22-imports |
Reverted. |
|
@pytorchbot revert -c nosignal -m "recognize |
|
@pytorchbot successfully started a revert job. Check the current status here. |
… Path` (#129426)" This reverts commit 6d75604. Reverted #129426 on behalf of https://github.com/XuehaiPan due to recognize `Path` as new exported API ([comment](#129426 (comment)))
|
@XuehaiPan your PR has been successfully reverted. |
ghstack-source-id: 4d3fbc5 Pull Request resolved: pytorch#129426
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 2 checks: inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f "previously failed ci passed" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge -f "previously failed ci passed" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: X-link: pytorch/pytorch#129426 Approved by: https://github.com/malfet Reviewed By: jeanschmidt Differential Revision: D59204337 fbshipit-source-id: 9fb7681c3a1e5e02b79a56a70a6702315e680f77
…ytorch#129426) Pull Request resolved: pytorch#129426 Approved by: https://github.com/malfet
… Path` (pytorch#129426)" This reverts commit 6d75604. Reverted pytorch#129426 on behalf of https://github.com/XuehaiPan due to recognize `Path` as new exported API ([comment](pytorch#129426 (comment)))
…ytorch#129426) Pull Request resolved: pytorch#129426 Approved by: https://github.com/malfet
Stack from ghstack (oldest at bottom):
path.resolve()->path.absolute()#129409pathlib.Pathinstead ofdirname/".."/pardir#129374import pathlibwithfrom pathlib import Path#129426cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire