[BE][Easy] enable postponed annotations in torchgen
#129376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129376
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit daa098e with merge base 065c386 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 24, 2024
|
Postponed annotations are actually being deprecated in the most recent version of python so I'd rather not enable them for no reason. In fact, I'd rather we disable them everywhere we can. I'm working on adding a ruff rule to enable this. |
|
See #117449 |
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 27, 2024
ghstack-source-id: 203eb2c Pull Request resolved: pytorch#129376
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 27, 2024
ghstack-source-id: 29cbd2f Pull Requestresolved: pytorch#129376
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 28, 2024
…ub files (#129419) ------ - [Generic TypeAlias (PEP 585)](https://peps.python.org/pep-0585): e.g. `typing.List[T] -> list[T]`, `typing.Dict[KT, VT] -> dict[KT, VT]`, `typing.Type[T] -> type[T]`. - [Union Type (PEP 604)](https://peps.python.org/pep-0604): e.g. `Union[X, Y] -> X | Y`, `Optional[X] -> X | None`, `Optional[Union[X, Y]] -> X | Y | None`. Note that in `.pyi` stub files, we do not need `from __future__ import annotations`. So this PR does not violate issue #117449: - #117449 Pull Request resolved: #129419 Approved by: https://github.com/ezyang ghstack dependencies: #129375, #129376
pytorchmergebot
added a commit
8000
that referenced
this pull request
Jun 29, 2024
This reverts commit 494057d. Reverted #129376 on behalf of https://github.com/huydhn due to Sorry for reverting your change but I need to revert to cleanly revert #129374, please do a rebase and reland this ([comment](#129375 (comment)))
|
@XuehaiPan your PR has been successfully reverted. |
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 29, 2024
ghstack-source-id: 4eae041 Pull Request resolved: pytorch#129376
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 29, 2024
…ub files (#129419) ------ - [Generic TypeAlias (PEP 585)](https://peps.python.org/pep-0585): e.g. `typing.List[T] -> list[T]`, `typing.Dict[KT, VT] -> dict[KT, VT]`, `typing.Type[T] -> type[T]`. - [Union Type (PEP 604)](https://peps.python.org/pep-0604): e.g. `Union[X, Y] -> X | Y`, `Optional[X] -> X | None`, `Optional[Union[X, Y]] -> X | Y | None`. Note that in `.pyi` stub files, we do not need `from __future__ import annotations`. So this PR does not violate issue #117449: - #117449 Pull Request resolved: #129419 Approved by: https://github.com/ezyang ghstack dependencies: #129375, #129376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
.pyistub files #129420.pyistub files #129419torchgen#129376tools#129375cc @ezyang @malfet @xuzhao9 @gramster @albanD