8000 Use Generic TypeAlias (PEP 585) and Union Type (PEP 604) in `.pyi` stub files by XuehaiPan · Pull Request #129419 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Use Generic TypeAlias (PEP 585) and Union Type (PEP 604) in .pyi stub files #129419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

Use Generic TypeAlias (PEP 585) and Union Type (PEP 604) in .pyi stub files #129419

wants to merge 15 commits into from

Conversation

XuehaiPan
Copy link
Collaborator
@XuehaiPan XuehaiPan commented Jun 24, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

  • Generic TypeAlias (PEP 585): e.g. typing.List[T] -> list[T], typing.Dict[KT, VT] -> dict[KT, VT], typing.Type[T] -> type[T].
  • Union Type (PEP 604): e.g. Union[X, Y] -> X | Y, Optional[X] -> X | None, Optional[Union[X, Y]] -> X | Y | None.

Note that in .pyi stub files, we do not need from __future__ import annotations. So this PR does not violate issue #117449:

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k @ezyang @malfet @xuzhao9 @gramster @Skylion007

@XuehaiPan
Update
769f26a 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jun 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129419

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 67ea1e5 with merge base 065c386 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Jun 24, 2024
This was referenced Jun 24, 2024
Closed
Closed
Closed
Closed
Closed
@XuehaiPan XuehaiPan added module: typing Related to mypy type annotations better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category labels Jun 24, 2024
@XuehaiPan XuehaiPan requested review from ezyang and Skylion007 June 24, 2024 23:09
@XuehaiPan
Update
2971b3c 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jun 25, 2024
Closed
XuehaiPan added 2 commits June 25, 2024 08:32
@XuehaiPan
Update
71f1e02 
[ghstack-poisoned]
@XuehaiPan
Update
3f6d16e 
[ghstack-poisoned]
@XuehaiPan XuehaiPan added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Jun 25, 2024
@XuehaiPan
Update
434cef2 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jun 28, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'all tests passed, stuck at unrelated ci' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -f "all tests passed, stuck at unrelated ci"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007
Copy link
Collaborator
Skylion007 commented Jun 28, 2024 •
edited
Loading

Ugh, I fear this might break any older torch.jit code which never supported PEP585, but we will see. Oh nvm, it's just PYI files, that's fine.

pytorchmergebot added a commit that referenced this pull request Jun 29, 2024
@pytorchmergebot
Revert "Use Generic TypeAlias (PEP 585) and Union Type (PEP 604) in `…
83caf49 
….pyi` stub files (#129419)"

This reverts commit e40f50c.

Reverted #129419 on behalf of https://github.com/huydhn due to Sorry for reverting your change but I need to revert to cleanly revert #129374, please do a rebase and reland this ([comment](#129375 (comment)))
@pytorchmergebot
Copy link
Collaborator

@XuehaiPan your PR has been successfully reverted.

XuehaiPan added 2 commits June 29, 2024 12:26
@XuehaiPan
Update
02415f1 
[ghstack-poisoned]
@XuehaiPan
Update
67ea1e5 
[ghstack-poisoned]
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 29, 2024
@XuehaiPan
Use Generic TypeAlias (PEP 585) and Union Type (PEP 604) in .pyi st…
078ade5 
…ub files

ghstack-source-id: 2b30591
Pull Request resolved: pytorch#129419
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: periodic / win-vs2019-cuda11.8-py3 / test (default, 3, 4, windows.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@XuehaiPan XuehaiPan removed the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Jun 29, 2024
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -f "failed test unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@XuehaiPan XuehaiPan mentioned this pull request Jun 30, 2024
Closed
@github-actions github-actions bot deleted the gh/XuehaiPan/71/head branch July 31, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@albanD albanD Awaiting requested review from albanD

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged module: typing Related to mypy type annotations oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (c10d) release notes category Reverted topic: not user facing topic category
4A4D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuehaiPan @pytorchmergebot @Skylion007 @ezyang @pytorchbot
0