10000 normalize strings by starry-shivam · Pull Request #2661 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]
Skip to content

normalize strings #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

normalize strings #2661

wants to merge 14 commits into from

Conversation

starry-shivam
Copy link
Member
@starry-shivam starry-shivam commented Sep 15, 2021 •
edited by Bibo-Joshi
Loading

Closes #2650

  • before merging, merge v14 into this
  • make sure that all PRs merge v14 after this is merged

Bibo-Joshi and others added 13 commits September 9, 2021 07:51
@Bibo-Joshi
Temporarily enable tests for the v14 branch
63e1bab
@harshil21 @Bibo-Joshi
Move and Rename TelegramDecryptionError to telegram.error.PassportDec…
4598eea 
…ryptionError (#2621)

* move telegramdecryptionerror to error.py

* Change error class name
@Poolitzer @Bibo-Joshi
Add Code Comment Guidelines to Contribution Guide (#2612)
d7366fc 
* feat: add docs about docs

* fix: improve looks

* fix: make link work

* fix: this looks better

* Improved markdown, updated link

* Less justifying

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@revolter @Bibo-Joshi
Improve Type Hinting for CallbackContext (#2587)
5b3983d 
* Fix incomplete type annotations for CallbackContext

Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
@Poolitzer @Bibo-Joshi
Add Custom pytest Marker to Ease Development (#2628)
df2e48f 
* Feat: Custom pytest marker

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@starry-shivam @Bibo-Joshi
Make BasePersistence Methods Abstract (#2624)
e72ca06 
* Make basepersistence methods abstractmethod

Signed-off-by: starry69 <starry369126@outlook.com>

Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
@Bibo-Joshi
Refactor Initialization of Persistence Classes (#2604)
60f6c38
@harshil21 @Bibo-Joshi
Remove __dict__ from __slots__ and drop Python 3.6 (#2619, #2636)
fe60272
@iota-008 @Bibo-Joshi
Remove day_is_strict argument of JobQueue.run_monthly (#2634)
df81477 
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
@Poolitzer @Bibo-Joshi
Drop Non-CallbackContext API (#2617)
f857f06
@harshil21 @Bibo-Joshi
Fix Signatures and Improve test_official (#2643)
a717db8
@Bibo-Joshi
Remove Deprecated Functionality (#2644)
12fe042
@harshil21
Use Parallel Execution Of Pylint (#2658)
b0ea2cc
github-actions[bot]
github-actions bot reviewed Sep 15, 2021
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@starry-shivam starry-shivam changed the base branch from master to v14 September 15, 2021 12:34
@tsnoam Telegram GithubBot Revised
Copy link
Member
tsnoam commented Sep 15, 2021

@starry69 I strongly recommend to only merge such work as the last thing before v14 release.

It will make all concurrent work on development branches annoying.

@tsnoam Telegram GithubBot Revised
Copy link
Member
tsnoam commented Sep 15, 2021

@starry69 I mean, merging earlier will cause such annoyance.

@starry-shivam
normalize strings
906cdd8 
Signed-off-by: starry69 <starry369126@outlook.com>
@harshil21 harshil21 added this to the v14 milestone Oct 15, 2021
@harshil21 harshil21 added the misc label Oct 15, 2021
@Bibo-Joshi Bibo-Joshi force-pushed the v14 branch 3 times, most recently from 5c26c91 to 74c4270 Compare December 13, 2021 18:14
@Bibo-Joshi
Copy link
Member

I'll close this for now, since it won't get merged in the forseeable future and just opening a new PR is less work than bringin this one up to date …
we'll probably revisit once we have a v14 release or so …

@Bibo-Joshi Bibo-Joshi closed this Jan 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2022
@Bibo-Joshi Bibo-Joshi deleted the str-normalization branch May 6, 2022 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.

Unify quotes
7 participants
@starry-shivam @tsnoam @Bibo-Joshi @harshil21 @Poolitzer @revolter @iota-008
0