8000 Unify quotes · Issue #2650 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]
Skip to content

Unify quotes #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bibo-Joshi opened this issue Sep 7, 2021 · 0 comments
Closed

Unify quotes #2650

Bibo-Joshi opened this issue Sep 7, 2021 · 0 comments
Milestone
v20.0a0

Comments

@Bibo-Joshi
Copy link
Member
Bibo-Joshi commented Sep 7, 2021 •
edited
Loading

… by dropping

python-telegram-bot/pyproject.toml

Line 4 in 0c50850

skip-string-normalization = true

Can be done e.g. before we start with stage 2 of v14 or just before releasing.

edit: we can probably also remove these lines:

python-telegram-bot/pyproject.toml

Lines 6 to 11 in 92cb6f3

# We need to force-exclude the negated include pattern
# so that pre-commit run --all-files does the correct thing
# see https://github.com/psf/black/issues/1778
force-exclude = '^(?!/(telegram|examples|tests)/).*\.py$'
include = '(telegram|examples|tests)/.*\.py$'
exclude = 'telegram/vendor'

so that black just runs on everything. shouldn't be a problem, especially in combination with this
@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Sep 7, 2021
@starry-shivam starry-shivam mentioned this issue Sep 15, 2021
Closed
2 tasks
@harshil21 harshil21 added the misc label Nov 6, 2021
@Bibo-Joshi Bibo-Joshi mentioned this issue Apr 24, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging a pull request may close this issue.

normalize strings python-telegram-bot/python-telegram-bot
2 participants
@Bibo-Joshi @harshil21
0