8000 CSI guideline by Poolitzer · Pull Request #2612 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]

Skip to content

CSI guideline #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 11, 2021
Merged

CSI guideline #2612

merged 7 commits into from
Aug 11, 2021

Conversation

Poolitzer
Copy link
Member
@Poolitzer Poolitzer commented Aug 1, 2021

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

closes #2333

Copy link
Member
@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the overall structure 👍 Just added a few comments - IMHO we don't need to justify ourselfs in the contrib guide …

Poolitzer and others added 2 commits August 11, 2021 11:56
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@Bibo-Joshi Bibo-Joshi merged commit b37f9d2 into v14 Aug 11, 2021
@Bibo-Joshi Bibo-Joshi deleted the intitial-csi branch August 11, 2021 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0