8000 bpo-40025: Require _generate_next_value_ to be defined before members by abbyonstott · Pull Request #19098 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-40025: Require _generate_next_value_ to be defined before members #19098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 28, 2020
Merged

bpo-40025: Require _generate_next_value_ to be defined before members #19098

merged 10 commits into from
Apr 28, 2020

Conversation

abbyonstott
Copy link
Contributor
@abbyonstott abbyonstott commented Mar 21, 2020 •
edited
Loading

8000
ethanfurman
ethanfurman requested changes Mar 21, 2020
View reviewed changes
Copy link
Member
@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note in the docs about _generate_next_value_ needing to be defined before any members are.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tirkarthi
Copy link
Member

Could this also have a test about the order raising TypeError?

@abbyonstott
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

ethanfurman
ethanfurman requested changes Mar 22, 2020
View reviewed changes
Copy link
Member
@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer -- thank you for persevering!

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@abbyonstott
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

ethanfurman
ethanfurman requested changes Mar 29, 2020
View reviewed changes
Copy link
Member
@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A couple minor changes and we should be good to go.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@abbyonstott
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

ethanfurman
ethanfurman approved these changes Apr 28, 2020
View reviewed changes
@ethanfurman ethanfurman merged commit d9a43e2 into python:master Apr 28, 2020
@ethanfurman ethanfurman self-assigned this Apr 28, 2020
@miss-islington
Copy link
Contributor

Thanks @ethanonstott for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @ethanonstott for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-19762 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 28, 2020
@abbyonstott @miss-islington
bpo-40025: Require _generate_next_value_ to be defined before members (…
7212fbe 
…pythonGH-19098)

require `_generate_next_value_` to be defined before members
(cherry picked from commit d9a43e2)

Co-authored-by: Ethan Onstott <storm@stormprograms.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 28, 2020
@abbyonstott @miss-islington
bpo-40025: Require _generate_next_value_ to be defined before members (…
4b53ffd 
…pythonGH-19098)

require `_generate_next_value_` to be defined before members
(cherry picked from commit d9a43e2)

Co-authored-by: Ethan Onstott <storm@stormprograms.com>
@bedevere-bot
Copy link

GH-19763 is a backport of this pull request to the 3.8 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

@ethanfurman ethanfurman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abbyonstott @bedevere-bot @tirkarthi @miss-islington @ethanfurman @the-knights-who-say-ni
0