8000 bpo-40025: Require _generate_next_value_ to be defined before members by abbyonstott · Pull Request #19098 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-40025: Require _generate_next_value_ to be defined before members #19098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 28, 2020
Merged

bpo-40025: Require _generate_next_value_ to be defined before members #19098

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b09b148
Require _generate_next_value_ to be defined before members
abbyonstott Mar 21, 2020
f74f34e
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 21, 2020
b8c1358
add name to ACKS
abbyonstott Mar 21, 2020
20b0ba3
Evaluate self._member_names for truthiness
abbyonstott Mar 21, 2020
186953c
Specify when _generate_next_value_ must be defined
abbyonstott Mar 21, 2020
a386b25
Add test for TypeError raised on incorrect order
abbyonstott Mar 21, 2020
6e15316
Fix whitespace
abbyonstott Mar 21, 2020
28094cf
Specify which error is raised
abbyonstott Mar 22, 2020
c1057d3
Add auto_called attribute to _EnumDict
abbyonstott Mar 22, 2020
8ad99d2
Always set self._auto_called to True
abbyonstott Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ def __setitem__(self, key, value):
):
raise ValueError('_names_ are reserved for future Enum use')
if key == '_generate_next_value_':
# check if members already defined
if len(self._member_names) > len(dir(super)):
raise TypeError("_generate_next_value_ must be defined before members")
setattr(self, '_generate_next_value', value)
elif key == '_ignore_':
if isinstance(value, str):
Expand Down
1 change: 1 addition & 0 deletions Misc/ACKS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,6 +1236,7 @@ Adam Olsen
Bryan Olson
Grant Olson
Koray Oner
Ethan Onstott
Piet van Oostrum
Tomas Oppelstrup
Jason Orendorff
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2020-03-21-05-26-38.bpo-40025.DTLtyq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Throw error when _generate_next_value_ is defined after members. Patch by Ethan Onstott.
0