8000 [FW][FIX] base_vat: correct the check and the reference of Israeli VAT numbers by fw-bot · Pull Request #173767 · odoo/odoo · GitHub
[go: up one dir, main page]
Skip to content

[FW][FIX] base_vat: correct the check and the reference of Israeli VAT numbers #173767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FW][FIX] base_vat: correct the check and the reference of Israeli VAT numbers #173767

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Contributor
@fw-bot fw-bot commented Jul 19, 2024 •
edited by mathcoutant
Loading

Issue:

The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one.

Steps to reproduce:

  • In app Contact, create a new one
  • Select Israel as country and enter a non-valid VAT number
  • The default ref is displayed: 'CC##' (CC=Country Code, ##=VAT Number)
  • And the number 039225313 should be accepted

Cause:

The check used by the library stdnum is not up-to-date.
There is a PR to modify the library stdnum: https://github.com/arthurdejong/python-stdnum/ PR436 as the law has changed. Before only corporations could have a VAT number, now individuals can also have one.

Solution:

Use the right check (tdnum.il.idnr), which is available in the library stdnum.

opw-3954674

Forward-Port-Of: #172760

@robodoo
Copy link
Contributor
robodoo commented Jul 19, 2024

Pull request status dashboard

@fw-bot
Copy link
Contributor Author
fw-bot commented Jul 19, 2024

@mathcoutant @FlorianGilbert cherrypicking of pull request #172760 failed.

stdout:

Auto-merging addons/base_vat/i18n/base_vat.pot
CONFLICT (content): Merge conflict in addons/base_vat/i18n/base_vat.pot
Auto-merging addons/base_vat/models/res_partner.py

stderr:

08:27:53.041086 git.c:463               trace: built-in: git cherry-pick 844b4f034640b4992dfee6cf4d916158b1ec1d09 --strategy ort
error: could not apply 844b4f034640... [FIX] base_vat: accept correct Israeli VAT numbers
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Jul 19, 2024
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Jul 19, 2024
@mathcoutant mathcoutant force-pushed the 17.0-16.0-opw-3954674-add_vat_ref_for_israel-mcou-3Iy1-fw branch from 54c320b to 8841a13 Compare July 19, 2024 07:54
@mathcoutant
[FIX] base_vat: accept correct Israeli VAT numbers
d3aa781 
Issue:
The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one.

Steps to reproduce:
- In app Contact, create a new one
- Select Israel as country and enter a non valid VAT number
- The default ref is displayed: 'CC##' (CC=Country Code, ##=VAT Number)
- And the number 039225313 should be accepted

Cause:
The check used by the library stdnum is not up to date.
There is a PR to modify the library stdnum: https://github.com/arthurdejong/python-stdnum/ PR436 as the law has changed. Before only corporations could have a VAT number, now individuals can also have one.
The new regulations give different formats for comanies and individuals.

Solution:
Use the right check (tdnum.il.idnr) for individuals, which is available in the library stdnum.

opw-395467
@mathcoutant mathcoutant force-pushed the 17.0-16.0-opw-3954674-add_vat_ref_for_israel-mcou-3Iy1-fw branch from 8841a13 to d3aa781 Compare July 19, 2024 07:56
@mathcoutant
Copy link
Contributor

@robodoo r+

@robodoo robodoo closed this in b05e203 Jul 19, 2024
This was referenced Jul 19, 2024
Closed
Closed
Closed
Closed
@fw-bot fw-bot deleted the 17.0-16.0-opw-3954674-add_vat_ref_for_israel-mcou-3Iy1-fw branch August 2, 2024 11:46
riccardoSANEHO pushed a commit to resultrum/odoo that referenced this pull request Sep 30, 2024
@mathcoutant @riccardoSANEHO
[FIX] base_vat: accept correct Israeli VAT numbers
3785bde 
Issue:
The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one.

Steps to reproduce:
- In app Contact, create a new one
- Select Israel as country and enter a non valid VAT number
- The default ref is displayed: 'CC##' (CC=Country Code, ##=VAT Number)
- And the number 039225313 should be accepted

Cause:
The check used by the library stdnum is not up to date.
There is a PR to modify the library stdnum: https://github.com/arthurdejong/python-stdnum/ PR436 as the law has changed. Before only corporations could have a VAT number, now individuals can also have one.
The new regulations give different formats for comanies and individuals.

Solution:
Use the right check (tdnum.il.idnr) for individuals, which is available in the library stdnum.

opw-395467

closes odoo#173767

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Mathieu Coutant (mcou) <mcou@odoo.com>
cybernexus pushed a commit to Cybernexus-Solutions/cs-odoo-17 that referenced this pull request Nov 19, 2024
@mathcoutant @cybernexus
[FIX] base_vat: accept correct Israeli VAT numbers
a5f61ab 
Issue:
The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one.

Steps to reproduce:
- In app Contact, create a new one
- Select Israel as country and enter a non valid VAT number
- The default ref is displayed: 'CC##' (CC=Country Code, ##=VAT Number)
- And the number 039225313 should be accepted

Cause:
The check used by the library stdnum is not up to date.
There is a PR to modify the library stdnum: https://github.com/arthurdejong/python-stdnum/ PR436 as the law has changed. Before only corporations could have a VAT number, now individuals can also have one.
The new regulations give different formats for comanies and individuals.

Solution:
Use the right check (tdnum.il.idnr) for individuals, which is available in the library stdnum.

opw-395467

closes odoo#173767

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Mathieu Coutant (mcou) <mcou@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fw-bot @robodoo @mathcoutant @C3POdoo
0