[FIX] base_vat: accept correct Israeli VAT numbers

mathcoutant · mathcoutant · commit d3aa781871a9 · 2024-07-19T09:55:46.000+02:00
Issue: The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one. Steps to reproduce: - In app Contact, create a new one - Select Israel as country and enter a non valid VAT number - The default ref is displayed: 'CC##' (CC=Country Code, ##=VAT Number) - And the number 039225313 should be accepted Cause: The check used by the library stdnum is not up to date. There is a PR to modify the library stdnum: https://github.com/arthurdejong/python-stdnum/ PR436 as the law has changed. Before only corporations could have a VAT number, now individuals can also have one. The new regulations give different formats for comanies and individuals. Solution: Use the right check (tdnum.il.idnr) for individuals, which is available in the library stdnum. opw-395467
diff --git a/addons/base_vat/i18n/base_vat.pot b/addons/base_vat/i18n/base_vat.pot
@@ -253,3 +253,10 @@ msgstr ""
 #, python-format
 msgid "partner [%s]"
 msgstr ""
+
+#. module: base_vat
+#. odoo-python
+#: code:addons/base_vat/models/res_partner.py:0
+#, python-format
+msgid "XXXXXXXXX [9 digits] and it should respect the Luhn algorithm checksum"
+msgstr ""
diff --git a/addons/base_vat/models/res_partner.py b/addons/base_vat/models/res_partner.py
@@ -49,6 +49,7 @@
     'hu': _('HU12345676 or 12345678-1-11 or 8071592153'),
     'hr': 'HR01234567896',  # Croatia, contributed by Milan Tribuson
     'ie': 'IE1234567FA',
+    'il': _('XXXXXXXXX [9 digits] and it should respect the Luhn algorithm checksum'),
     'in': "12AAAAA1234AAZA",
     'is': 'IS062199',
     'it': 'IT12345670017',
@@ -780,6 +781,10 @@ def check_vat_de(self, vat):
         is_valid_stnr = stdnum.util.get_cc_module("de", "stnr").is_valid
         return is_valid_vat(vat) or is_valid_stnr(vat)
 
+    def check_vat_il(self, vat):
+        check_func = stdnum.util.get_cc_module('il', 'hp').is_valid if self.is_company else stdnum.util.get_cc_module('il', 'idnr').is_valid
+        return check_func(vat)
+
     def format_vat_sm(self, vat):
         stdnum_vat_format = stdnum.util.get_cc_module('sm', 'vat').compact
         return stdnum_vat_format('SM' + vat)[2:]
