[FW][FIX] base_vat: correct the check and the reference of Israeli VAT numbers #173858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one. Steps to reproduce: - In app Contact, create a new one - Select Israel as country and enter a non valid VAT number - The default ref is displayed: 'CC##' (CC=Country Code, ##=VAT Number) - And the number 039225313 should be accepted Cause: The check used by the library stdnum is not up to date. There is a PR to modify the library stdnum: https://github.com/arthurdejong/python-stdnum/ PR436 as the law has changed. Before only corporations could have a VAT number, now individuals can also have one. The new regulations give different formats for comanies and individuals. Solution: Use the right check (tdnum.il.idnr) for individuals, which is available in the library stdnum. opw-395467 X-original-commit: b05e203
|
|
|
This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Jul 19, 2024
Issue: The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one. Steps to reproduce: - In app Contact, create a new one - Select Israel as country and enter a non valid VAT number - The default ref is displayed: 'CC##' (CC=Country Code, ##=VAT Number) - And the number 039225313 should be accepted Cause: The check used by the library stdnum is not up to date. There is a PR to modify the library stdnum: https://github.com/arthurdejong/python-stdnum/ PR436 as the law has changed. Before only corporations could have a VAT number, now individuals can also have one. The new regulations give different formats for comanies and individuals. Solution: Use the right check (tdnum.il.idnr) for individuals, which is available in the library stdnum. opw-395467 closes #173858 X-original-commit: b05e203 Signed-off-by: Florian Gilbert (flg) <flg@odoo.com> Signed-off-by: Mathieu Coutant (mcou) <mcou@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Jul 20, 2024
Issue: The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one. Steps to reproduce: - In app Contact, create a new one - Select Israel as country and enter a non valid VAT number - The default ref is displayed: 'CC##' (CC=Country Code, ##=VAT Number) - And the number 039225313 should be accepted Cause: The check used by the library stdnum is not up to date. There is a PR to modify the library stdnum: https://github.com/arthurdejong/python-stdnum/ PR436 as the law has changed. Before only corporations could have a VAT number, now individuals can also have one. The new regulations give different formats for comanies and individuals. Solution: Use the right check (tdnum.il.idnr) for individuals, which is available in the library stdnum. opw-395467 closes #173858 X-original-commit: b05e203 Signed-off-by: Florian Gilbert (flg) <flg@odoo.com> Signed-off-by: Mathieu Coutant (mcou) <mcou@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one.
Steps to reproduce:
Cause:
he check used by the library stdnum is not up-to-date.
There is a PR to modify the library stdnum: https://github.com/arthurdejong/python-stdnum/ PR436 as the law has changed. Before only corporations could have a VAT number, now individuals can also have one.
Solution:
Use the right check (tdnum.il.idnr), which is available in the library stdnum.
opw-3954674
Forward-Port-Of: #173767
Forward-Port-Of: #172760