8000 [FIX] coding_guidelines: Add comment to indicate ASCII-based ordering by hamo-odoo · Pull Request #12951 · odoo/documentation · GitHub
[go: up one dir, main page]
Skip to content

[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering #12951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering #12951

wants to merge 1 commit into from

Conversation

hamo-odoo
Copy link
Contributor

Following the fix - 92c7099 Adding a comment to explicitly indicate that the import is ordered alphabetically based on ASCII values.

@robodoo
Copy link
Collaborator
robodoo commented Apr 18, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team April 18, 2025 08:03
@hamo-odoo hamo-odoo mentioned this pull request Apr 18, 2025
Closed
AntoineVDV
AntoineVDV approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator
@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate+

@hamo-odoo
[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering
38e39a4 
Following the fix - 92c7099
Adding a comment to explicitly indicate that the import is ordered
alphabetically based on ASCII values.
@hamo-odoo hamo-odoo force-pushed the 16.0-coding-guidelines-ascii-comment-fix-hamo branch from e501925 to 38e39a4 Compare April 18, 2025 11:59
hamo-odoo
hamo-odoo commented Apr 18, 2025
View reviewed changes
Copy link
Contributor Author
@hamo-odoo hamo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 18, 2025
@hamo-odoo
[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering
a9577b5 
Following the fix - 92c7099
Adding a comment to explicitly indicate that the import is ordered
alphabetically based on ASCII values.

closes #12951

Signed-off-by: Harsh Modi (hamo) <hamo@odoo.com>
@FlorianGilbert
Copy link
Contributor

Thanks guys!

@robodoo robodoo closed this Apr 18, 2025
This was referenced Apr 18, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineVDV AntoineVDV AntoineVDV approved these changes

@FlorianGilbert FlorianGilbert Awaiting requested review from FlorianGilbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hamo-odoo @robodoo @FlorianGilbert @AntoineVDV
0