[FIX] coding_guidelines: fix the alphabetic orders for the import #11983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
149e329 to
c48c949
Compare
c48c949 to
ce4ed9b
Compare
AntoineVDV
approved these changes
Feb 7, 2025
ce4ed9b to
5a148d5
Compare
|
@AntoineVDV Done, Re-targeting to |
In odoo, as we suggest everyone to follow an alphebetic order. The translator(`_`), ASCII is 95 and `a` ASCII value is 97 which '_' < 'a', the translator should be defined first in the import before the `api` not at the end of the import This commits adds an example to import static class `Command` with a Capital alphabet with a ASCII value of `C` as 67 which will be before than the `_` 'C' < '_' < 'a' This order of import should be followed while the import
5a148d5 to
92c7099
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 7, 2025
In odoo, as we suggest everyone to follow an alphebetic order. The translator(`_`), ASCII is 95 and `a` ASCII value is 97 which '_' < 'a', the translator should be defined first in the import before the `api` not at the end of the import This commits adds an example to import static class `Command` with a Capital alphabet with a ASCII value of `C` as 67 which will be before than the `_` 'C' < '_' < 'a' This order of import should be followed while the import closes #11983 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
This was referenced Feb 7, 2025
|
Hello @AntoineVDV and @hamo-odoo |
I'm planning on rewriting the whole guidelines soon™, so until then, I merge all change requests that go in the right direction, and I will elaborate further during the rewrite. |
For the reference, I have created the PR- #12951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In odoo, as we suggest everyone to follow an alphebetic order.
The translator(
_), ASCII is 95 andaASCII value is 97 which '_' < 'a', the translator should be defined first in the import before theapinot at the end of the importThis commits adds an example to import static class
Commandwith a Capital alphabet with a ASCII value ofCas 67 which will be before than the_'C' < '_' < 'a'
This order of import should be followed while the import