8000 [FW][FIX] coding_guidelines: Add comment to indicate ASCII-based ordering by fw-bot · Pull Request #12982 · odoo/documentation · GitHub
[go: up one dir, main page]
Skip to content

[FW][FIX] coding_guidelines: Add comment to indicate ASCII-based ordering #12982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. 8000 We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FW][FIX] coding_guidelines: Add comment to indicate ASCII-based ordering #12982

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator
@fw-bot fw-bot commented Apr 21, 2025

Following the fix - 92c7099 Adding a comment to explicitly indicate that the import is ordered alphabetically based on ASCII values.

Forward-Port-Of: #12962
Forward-Port-Of: #12951

@hamo-odoo
[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering
a886249 
Following the fix - 92c7099
Adding a comment to explicitly indicate that the import is ordered
alphabetically based on ASCII values.

X-original-commit: 8bfb5d5
@robodoo
Copy link
Collaborator
robodoo commented Apr 21, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author
fw-bot commented Apr 21, 2025

@hamo-odoo this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

hamo-odoo
hamo-odoo approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor
@hamo-odoo hamo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 21, 2025
@hamo-odoo
[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering
3c09217 
Following the fix - 92c7099
Adding a comment to explicitly indicate that the import is ordered
alphabetically based on ASCII values.

closes #12982

X-original-commit: 8bfb5d5
Signed-off-by: Harsh Modi (hamo) <hamo@odoo.com>
@robodoo
Copy link
Collaborator
robodoo commented Apr 21, 2025

@hamo-odoo staging failed: ci/runbot on 895ecab0537c0f8e0a7294feaf244f4bf2572550 (view more at https://runbot.odoo.com/runbot/build/78799052)

@d-fence
Copy link
Contributor
d-fence commented Apr 21, 2025

robodoo retry
(failing test neutralized)

robodoo pushed a commit that referenced this pull request Apr 21, 2025
@hamo-odoo
[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering
ca663d2 
Following the fix - 92c7099
Adding a comment to explicitly indicate that the import is ordered
alphabetically based on ASCII values.

closes #12982

X-original-commit: 8bfb5d5
Signed-off-by: Harsh Modi (hamo) <hamo@odoo.com>
robodoo pushed a commit that referenced this pull request Apr 21, 2025
@hamo-odoo
[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering
8000
bb460f3 
Following the fix - 92c7099
Adding a comment to explicitly indicate that the import is ordered
alphabetically based on ASCII values.

closes #12982

X-original-commit: 8bfb5d5
Signed-off-by: Harsh Modi (hamo) <hamo@odoo.com>
robodoo pushed a commit that referenced this pull request Apr 21, 2025
@hamo-odoo
[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering
0679a8f 
Following the fix - 92c7099
Adding a comment to explicitly indicate that the import is ordered
alphabetically based on ASCII values.

closes #12982

X-original-commit: 8bfb5d5
Signed-off-by: Harsh Modi (hamo) <hamo@odoo.com>
robodoo pushed a commit that referenced this pull request Apr 21, 2025
@hamo-odoo
[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering
04520ab 
Following the fix - 92c7099
Adding a comment to explicitly indicate that the import is ordered
alphabetically based on ASCII values.

closes #12982

X-original-commit: 8bfb5d5
Signed-off-by: Harsh Modi (hamo) <hamo@odoo.com>
@robodoo
Copy link
Collaborator
robodoo commented Apr 21, 2025

@hamo-odoo staging failed: ci/runbot on d4ac7caf5980536d57e8e1a7e0b7ef7727b75e3f (view more at https://runbot.odoo.com/runbot/build/78802101)

@hamo-odoo
Copy link
Contributor

@robodoo retry

robodoo pushed a c 9A52 ommit that referenced this pull request Apr 22, 2025
@hamo-odoo
[FIX] coding_guidelines: Add comment to indicate ASCII-based ordering
226ce89 
Following the fix - 92c7099
Adding a comment to explicitly indicate that the import is ordered
alphabetically based on ASCII values.

closes #12982

X-original-commit: 8bfb5d5
Signed-off-by: Harsh Modi (hamo) <hamo@odoo.com>
@robodoo robodoo added the 18.3 label Apr 22, 2025
@robodoo robodoo closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamo-odoo hamo-odoo hamo-odoo approved these changes

Assignees
No one assigned
Labels
18.3 forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fw-bot @robodoo @d-fence @hamo-odoo
0