BLD: fix for INTEL compiler build failure on linux when import msvc #6211
Conversation
| from distutils.unixccompiler import UnixCCompiler | ||
| from numpy.distutils.exec_command import find_executable | ||
| from distutils.msvc9compiler import MSVCCompiler | ||
| if sys.platform == 'win32': | ||
| from distutils.msvc9compiler import MSVCCompiler |
There was a problem hiding this comment.
Might be better to move this import down under the other if statement.
There was a problem hiding this comment.
Thanks Charris. I think it's a good idea. :)
| self.compile_options_debug = ['/nologo', '/Od', '/MDd', '/W3', | ||
| if sys.platform == 'win32': | ||
| from distutils.msvc9compiler import MSVCCompiler | ||
| class IntelCCompilerW(MSVCCompiler): |
There was a problem hiding this comment.
Strictly speaking, should have two blank lines above the class declaration. It is useful to run pep8 over code just to keep it more or less in line.
There was a problem hiding this comment.
Charris, thanks for letting me know this. I just tried the pep8 online checker and correct serveral coding styles errors.
|
LGTM modulo a style nitpick. |
…x when importing MSVC
BLD: fix for INTEL compiler build failure on linux when import msvc
|
Thanks @yolanda15. |
|
@yolanda15 you can use this to configure your git setup: Then your name will show up correctly in the commit log next time. |
Backport of gh-6211 - fix Linux build with Intel compilers
|
Thank you very much @rgommers :) |
Intel compiler build on Linux fails due to MSVC related changes in master and 1.10.x:
NameError: name 'MSVCCompiler' is not defined
Try checking system platform before including MSVC related code for Windows.