10000 BLD: fix for INTEL compiler build failure on linux when import msvc by yolanda15 · Pull Request #6211 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BLD: fix for INTEL compiler build failure on linux when import msvc #6211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2015
Merged

BLD: fix for INTEL compiler build failure on linux when import msvc #6211

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84e39ce
fix for linux build break with msvc
yolanda15 Aug 18, 2015
facea22
BLD: add platform check to avoid intel compiler build failure on Linu…
yolanda15 Aug 19, 2015
e76eb27
STY: fix for PEP8 online check
yolanda15 Aug 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
10000 Loading
Diff view
Diff view
Prev Previous commit
STY: fix for PEP8 online check
  • Loading branch information
@yolanda15
yolanda15 committed Aug 20, 2015
commit e76eb2724f143fbba82dbbf251b1d9417376e6a2
13 changes: 7 additions & 6 deletions numpy/distutils/intelccompiler.py
View file
Open in desktop
82A8
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ def __init__(self, verbose=0, dry_run=0, force=0):

if sys.platform == 'win32':
from distutils.msvc9compiler import MSVCCompiler

class IntelCCompilerW(MSVCCompiler):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, should have two blank lines above the class declaration. It is useful to run pep8 over code just to keep it more or less in line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Charris, thanks for letting me know this. I just tried the pep8 online checker and correct serveral coding styles errors.

"""
A modified Intel compiler on Windows compatible with an MSVC-built Python.
A modified Intel compiler compatible with an MSVC-built Python.
"""
compiler_type = 'intelw'

Expand All @@ -73,14 +74,15 @@ def initialize(self, plat_name=None):
self.cc = self.find_exe("icl.exe")
self.lib = self.find_exe("xilib")
self.linker = self.find_exe("xilink")
self.compile_options = ['/nologo', '/O3', '/MD', '/W3', '/Qstd=c99']
self.compile_options = ['/nologo', '/O3', '/MD', '/W3',
'/Qstd=c99']
self.compile_options_debug = ['/nologo', '/Od', '/MDd', '/W3',
'/Qstd=c99', '/Z7', '/D_DEBUG']

'/Qstd=c99', '/Z7', '/D_DEBUG']

class IntelEM64TCCompilerW(IntelCCompilerW):
"""
A modified Intel x86_64 compiler compatible with a 64bit MSVC-built Python.
A modified Intel x86_64 compiler compatible with
a 64bit MSVC-built Python.
"""
compiler_type = 'intelemw'

Expand All @@ -89,4 +91,3 @@ def __init__(self, verbose=0, dry_run=0, force=0):
version_match = simple_version_match(start='Intel\(R\).*?64,')
self.__version = version_match


0