8000 BLD: fix various issues for Intel Fortran and GFortran by rgommers · Pull Request #6169 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BLD: fix various issues for Intel Fortran and GFortran #6169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2015
Merged

BLD: fix various issues for Intel Fortran and GFortran #6169

merged 2 commits into from
Aug 21, 2015

Conversation

rgommers
Copy link
Member
@rgommers rgommers commented Aug 5, 2015

Closes gh-6095. Note that I haven't been able to test this, fixes are based on Intel docs and the description in gh-6095.

Note: each commit message has a more detailed description and links to the relevant page of the Intel docs.

@rgommers
Copy link
Member Author
rgommers commented Aug 5, 2015

@slishak thanks for the details bug report. All issues you brought up should now be fixed after this PR is merged. Can you please verify that things now work as expected for you with this PR?

@charris
Copy link
Member
charris commented Aug 6, 2015

Looks straight forward.

@rgommers
Copy link
Member Author

Hold on with merging this - got some offline feedback that needs addressing.

@slishak
Copy link
slishak commented Aug 17, 2015

Thanks for the fix. Unfortunately I'm currently unable to test it as I had the compilers on an evaluation license, but will come back to it soon.

@charris
Copy link
Member
charris commented Aug 17, 2015

@rgommers Anything more? Also see #6211.

@rgommers
Copy link
Member Author

Third commit apparently not necessary. Feedback from @yolanda15:

For Win 32 build, “lib.exe” is used as archiver and “/OUT”
is the correct argument for lib.exe

So removing it.

@rgommers
Copy link
Member Author

For the second commit, /DLL should come from Python distutils; 32-bit MSVC build contains:

creating build\lib.win32-3.4\scipy\cluster
xilink /DLL /nologo /INCREMENTAL:NO /LIBPATH:"C:\Program Files (x86)\Intel\Composer XE 2015.1.148\mkl\lib\ia32" ...<etc>

So if @slishak cannot test and it doesn't seem to be needed, then better to leave out this commit for now (I'm not yet convinced it's wrong though).

@rgommers
Copy link
Member Author

@charris updated. This should now be very straightforward and can be put into 1.10.x as well I think.

charris added a commit that referenced this pull request Aug 21, 2015
@charris
Merge pull request #6169 from rgommers/intel-build
653a365 
BLD: fix various issues for Intel Fortran and GFortran
@charris charris merged commit 653a365 into numpy:master Aug 21, 2015
@charris
Copy link
Member
charris commented Aug 21, 2015

Thanks Ralf, I'll backport.

@charris charris mentioned this pull request Aug 21, 2015
Merged
@rgommers rgommers added this to the 1.10.0 release milestone Aug 21, 2015
@rgommers rgommers deleted the intel-build branch August 21, 2015 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug component: numpy.distutils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intel compilers not working with distutils
3 participants
@rgommers @charris @slishak
0