stm32/uart_repl: Disable irq flash erase/write if uart repl enabled. #8645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
734e46d to
a1fa176
Compare
dpgeorge
reviewed
May 27, 2022
| @@ -64,7 +64,9 @@ void storage_init(void) { | |||
| // Enable the flash IRQ, which is used to also call our storage IRQ handler | |||
| // It must go at the same priority as USB (see comment in irq.h). | |||
| NVIC_SetPriority(FLASH_IRQn, IRQ_PRI_FLASH); | |||
| #if (MICROPY_HW_FLASH_BACKGROUND_CACHE) || defined(MICROPY_HW_BDEV2_IOCTL) | |||
There was a problem hiding this comment.
I don't think this is needed, it can enable the IRQ unconditionally.
There was a problem hiding this comment.
I figured with this enabled all the time, there's an unneccesary (albeit miniscule) cpu overhead of having the now-empty irq function running on a regular basis.
There was a problem hiding this comment.
Ah, OK. Then maybe it's even better to just disable this line:
systick_enable_dispatch(SYSTICK_DISPATCH_STORAGE, storage_systick_callback);
Then you don't need to touch anything in flashbdev.c.
Ultimately I want to switch to a soft-timer based implementation for this storage flushing callback... but that can wait.
Uart repl stdin loses data when the background flash erase / cache flush happens during communication. This change forces all erase / write operations to happen during file sync/close instead. This change can be overridden in board config etc. with: #define MICROPY_HW_FLASH_BACKGROUND_CACHE (1) For more details see micropython#8386
a1fa176 to
f19f880
Compare
|
Closing in favour of #8713. |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Nov 28, 2023
ESP32-S3 BLE fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uart repl stdin loses data when the background flash erase / cache flush happens during communication.
This change forces all erase / write operations to happen during file sync/close instead.
This change can be overridden by defining MICROPY_HW_FLASH_BACKGROUND_CACHE (1) in board config.
For more details see: mpremote cannot cp files to stm32wb55 nucleo on stlink/com port. #8386
I'm not sure if there are likely to be other unintended side-effects of disabling this flash irq however?