stm32/nucleo_wb55: Fix mpremote file transfer over uart repl. #8713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs some isr and flash erase functions from ram.
dpgeorge
reviewed
Jun 3, 2022
|
|
||
| // Configure ram isr / functions for board. | ||
| extern void ram_isr_fn_init(); | ||
| #define MICROPY_BOARD_STARTUP ram_isr_fn_init |
There was a problem hiding this comment.
This should probably only be configured if USE_RAM_ISR_UART_FLASH_FN is enabled.
Also, maybe call it board_startup. And put void in the arg list.
dpgeorge
reviewed
Jun 3, 2022
| #include <py/mphal.h> | ||
|
|
||
| // This is the default MICROPY_BOARD_STARTUP on stm32 | ||
| extern void powerctrl_check_enter_bootloader(); |
There was a problem hiding this comment.
You should be able to include powerctrl.h to get this declaration.
|
TODO: this needs to be generalised to work on any stm32 board that needs it. |
|
This has been replaced / generalised in #9054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs some isr and flash erase functions from ram so the uart rx is not blocked by background flash operations.
This is intended to demonstrate an alternate solution to fixing #8386 on a per board/project basis.