8000 Don't warn when accessing deprecated properties from the class. by anntzer · Pull Request #12653 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Don't warn when accessing deprecated properties from the class. #12653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2018
Merged

Don't warn when accessing deprecated properties from the class. #12653

merged 1 commit into from
Oct 29, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Oct 27, 2018

Otherwise, we get a lot of spurious warnings from inspection tools such
as pydoc.

Partially reverts #12247. Closes half of #12650 (the other half is handled by #12652).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Don't warn when accessing deprecated properties from the class.
bb5d400 
Otherwise, we get a lot of spurious warnings from inspection tools such
as pydoc.
@anntzer anntzer added this to the v3.0.x milestone Oct 27, 2018
@jklymak
Copy link
Member
jklymak commented Oct 29, 2018

Is this needed after #12658?

jklymak
jklymak approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops I guess it is needed. Taking your word that this actually fixes the problem.

@tacaswell tacaswell merged commit 5eaa14c into matplotlib:master Oct 29, 2018
@lumberbot-app
Copy link
lumberbot-app bot commented Oct 29, 2018

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 5eaa14c05b226124fb9572ba63c1cf6b888b184d
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am "Backport PR #12653: Don't warn when accessing deprecated properties from the class."
  1. Push to a named branch :
git push YOURFORK v3.0.x:auto-backport-of-pr-12653-on-v3.0.x
  1. Create a PR against branch v3.0.x, I would have named this PR:

"Backport PR #12653 on branch v3.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the property-dont-warn-from-class branch October 29, 2018 19:31
@dstansby dstansby mentioned this pull request Oct 30, 2018
Closed
timhoffm pushed a commit to timhoffm/matplotlib that referenced this pull request Nov 1, 2018
@tacaswell @timhoffm
Backport PR matplotlib#12653: Don't warn when accessing deprecated pr…
7d4fa75 
…operties from the class.
@timhoffm timhoffm mentioned this pull request Nov 1, 2018
Merged
dstansby added a commit that referenced this pull request Nov 1, 2018
@dstansby
Merge pull request #12700 from timhoffm/auto-backport-of-pr-12653-on-…
6080c21 
…v3.0.x

Backport PR #12653: Don't warn when accessing deprecated properties f…
@anntzer anntzer mentioned this pull request Apr 23, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @tacaswell @timhoffm
0