Merge pull request #12653 from anntzer/property-dont-warn-from-class

tacaswell · web-flow · commit 5eaa14c05b22 · 2018-10-29T15:29:30.000-04:00
MNT: Don't warn when accessing deprecated properties from the class.
diff --git a/lib/matplotlib/cbook/deprecation.py b/lib/matplotlib/cbook/deprecation.py
@@ -201,18 +201,21 @@ def finalize(wrapper, new_doc):
 
             class _deprecated_property(property):
                 def __get__(self, instance, owner):
-                    from . import _warn_external
-                    _warn_external(message, category)
+                    if instance is not None:
+                        from . import _warn_external
+                        _warn_external(message, category)
                     return super().__get__(instance, owner)
 
                 def __set__(self, instance, value):
-                    from . import _warn_external
-                    _warn_external(message, category)
+                    if instance is not None:
+                        from . import _warn_external
+                        _warn_external(message, category)
                     return super().__set__(instance, value)
 
                 def __delete__(self, instance):
-                    from . import _warn_external
-                    _warn_external(message, category)
+                    if instance is not None:
+                        from . import _warn_external
+                        _warn_external(message, category)
                     return super().__delete__(instance)
 
             def finalize(_, new_doc):
