8000 Hide deprecated rcParams from rcParams.__iter__. by anntzer · Pull Request #12652 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Hide deprecated rcParams from rcParams.__iter__. #12652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Hide deprecated rcParams from rcParams.__iter__. #12652

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Oct 27, 2018

This avoids triggering a DeprecationWarning just from iterating over
rcParams.

Closes #12649.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Hide deprecated rcParams from rcParams.__iter__.
ac087f7 
This avoids triggering a DeprecationWarning just from iterating over
rcParams.
@anntzer anntzer added this to the v3.0.x milestone Oct 27, 2018
@anntzer anntzer mentioned this pull request Oct 27, 2018
Merged
6 tasks
@anntzer
Copy link
Contributor Author
anntzer commented Oct 28, 2018

Of course, this can be considered an API break in that someone may be relying on the deprecated rcparam being present in the iter() (while it won't be present anymore with this PR), but I can't think of anything better right now...

@timhoffm
Copy link
Member

What's the actual use-case this is targetting? I'm not completely convinced it's a good idea to leave valid rcParams out. Wondering if we cannot suppress the warning instead.

@anntzer
Copy link
Contributor Author
anntzer commented Oct 28, 2018

If you have a better fix for #12649 (I agree with the OP that the warnings are annoying), go for it.

@timhoffm timhoffm mentioned this pull request Oct 28, 2018
Merged
@anntzer
Copy link
Contributor Author
anntzer commented Oct 28, 2018

#12658 is clearly a better approach.

@anntzer anntzer closed this Oct 28, 2018
@anntzer anntzer deleted the hide-deprecated-rcparams branch October 28, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.2
Development

Successfully merging this pull request may close these issues.

Over-verbose deprecation warning about examples.directory
3 participants
@anntzer @timhoffm @jklymak
0