8000 [wip] Add machinery to generate test-only wheels. by anntzer · Pull Request #11732 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

[wip] Add machinery to generate test-only wheels. #11732

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[wip] Add machinery to generate test-only wheels. #11732

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jul 22, 2018 •
edited
Loading

Generate a matplotlib.tests wheel that can be uploaded to PyPI as a
separate PyPI package ("distribution", in distutils parlance), to make
it possible to install tests and test data from PyPI.

This is useful e.g. for mplcairo, whose test suite relies on
matplotlib's one.

attn @tacaswell (I think I remember there were also some discussions re: installing test data or not for conda packages.)
Basically undoing #11055, but in a way that now works...

Would be nice to have for 3.0, but heh :)

As a side point, note that the 2.2.2 manylinux wheel currently on PyPI contains baseline images for mpl_toolkits, but not for matplotlib itself...

Edit: Looks like there can be funny issues if matplotlib is editably installed as this PR causes matplotlib.tests.egg-info to end up in lib, next to matplotlib.egg-info...

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Add machinery to generate test-only wheels.
19a5889 
Generate a matplotlib.tests wheel that can be uploaded to PyPI as a
separate PyPI package ("distribution", in distutils parlance), to make
it possible to install tests and test data from PyPI.

This is useful e.g. for mplcairo, whose test suite relies on
matplotlib's one.
@tacaswell tacaswell added this to the v3.0 milestone Jul 22, 2018
@anntzer anntzer changed the title Add machinery to generate test-only wheels. [wip] Add machinery to generate test-only wheels. Jul 25, 2018
@jklymak jklymak modified the milestones: v3.0, v3.1 Aug 13, 2018
@tacaswell tacaswell closed this Feb 24, 2019
@tacaswell tacaswell reopened this Feb 24, 2019
@tacaswell
Copy link
Member

power-cycled to run against current master.

dopplershift
dopplershift approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor
@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me.

@anntzer
Copy link
Contributor Author
anntzer commented Feb 25, 2019

Needs some small additional changes to remove the tests from the default wheels and the configurability for that (so that the matplotlib.tests wheel doesn't overwrite stuff from the matplotlib wheel).

@anntzer anntzer modified the milestones: v3.1.0, v3.2.0 Mar 4, 2019
@anntzer
Copy link
Contributor Author
anntzer commented Mar 4, 2019 •
edited
Loading

Probably needs a bit more wrangling with our handling of setup.cfg/MANIFEST.in so remilestoning...

@anntzer anntzer mentioned this pull request May 8, 2019
Merged
6 tasks
@tacaswell tacaswell modified the milestones: v3.2.0, v3.3.0 Aug 27, 2019
@anntzer anntzer mentioned this pull request Mar 23, 2020
Closed
@SidharthBansal SidharthBansal mentioned this pull request Apr 10, 2020
Open
@QuLogic QuLogic modified the milestones: v3.3.0, v3.4.0 Apr 30, 2020
@SidharthBansal SidharthBansal mentioned this pull request May 17, 2020
Closed
@jklymak jklymak marked this pull request as draft July 23, 2020 16:37
@QuLogic QuLogic modified the milestones: v3.4.0, v3.5.0 Jan 21, 2021
@tacaswell tacaswell modified the milestones: v3.5.0, v3.6.0 Aug 5, 2021
@timhoffm timhoffm modified the milestones: v3.6.0, unassigned Apr 30, 2022
@story645 story645 modified the milestones: unassigned, needs sorting Oct 6, 2022
@github-actions
Copy link
github-actions bot commented May 9, 2023

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label May 9, 2023
@anntzer
Copy link
Contributor Author
anntzer commented May 9, 2023

This will likely be superseded by the new work on testing machinery.

@anntzer anntzer closed this May 9, 2023
@QuLogic QuLogic removed the status: inactive Marked by the “Stale” Github Action label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Build status: needs rebase status: work in progress topic: testing
Projects
None yet
Milestone
future releases
Development

Successfully merging this pull request may close these issues.
7 participants
@anntzer @tacaswell @dopplershift @QuLogic @story645 @jklymak @timhoffm
0