10000 Add machinery to generate test-only wheels. by SidharthBansal · Pull Request #17434 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Add machinery to generate test-only wheels. #17434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SidharthBansal
Copy link
Contributor
@SidharthBansal SidharthBansal commented May 17, 2020

PR Summary

Generate a matplotlib.tests wheel that can be uploaded to PyPI as a separate PyPI package ("distribution", in distutils parlance), to make it possible to install tests and test data from PyPI.

This is useful e.g. for mplcairo, whose test suite relies on matplotlib's one.
Also, useful for Baseline image problem optimisation.

Co-authored-by: @anntzer
Closes #11732
Thanks

Generate a matplotlib.tests wheel that can be uploaded to PyPI as a
separate PyPI package ("distribution", in distutils parlance), to make
it possible to install tests and test data from PyPI.

This is useful e.g. for mplcairo, whose test suite relies on
matplotlib's one.
@anntzer
Copy link
Contributor
anntzer commented May 17, 2020

As discussed elsewhere please explain what use cases this covers (mpl editable/non-editable, tests editable/non-editable) -- likely this will need to get some reworking to actually cover all cases, or at least error out cleanly in cases we really don't want to support (if any -- that also needs explanations).

@SidharthBansal SidharthBansal force-pushed the mpltest_and_mpl_package_division branch 9 times, most recently from 3bfd1d0 to 7fd5a02 Compare May 25, 2020 14:03
@SidharthBansal SidharthBansal marked this pull request as draft June 3, 2020 14:09
@SidharthBansal
Copy link
Contributor Author

We don't need the entire test suite to be shifted to another package. Only, baseline images create the problem, so they can be shifted to another package. Hence, we don't need this PR as we need baseline-images-only wheels.

Moved to #17557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0