8000 Remove setup_tests_only.py. by anntzer · Pull Request #11055 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove setup_tests_only.py. #11055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2018
Merged

Remove setup_tests_only.py. #11055

merged 1 commit into from
Apr 16, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Apr 16, 2018

That file was added in 42fa2b6 without comment as to why (and renamed in ab99e65 to avoid confusing pytest); calling python setup_test_only.py sdist (which I guess is the only reasonable thing to do with it -- it's distutils so you can't even build a wheel out of it) doesn't create a correct "tests-only" sdist either.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove setup_tests_only.py.
5c82032 
That file was added in 42fa2b6 without comment as to why (and renamed in
ab99e65 to avoid confusing pytest); calling `python setup_test_only.py
sdist` (which I guess is the only reasonable thing to do with it -- it's
distutils so you can't even build a wheel out of it) doesn't create a
correct "tests-only" sdist either.
@anntzer anntzer added this to the v3.0 milestone Apr 16, 2018
@tacaswell tacaswell merged commit 3719994 into matplotlib:master Apr 16, 2018
@anntzer anntzer deleted the remove-setup_tests_only branch April 16, 2018 19:45
@anntzer anntzer mentioned this pull request Jul 22, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dstansby @tacaswell
0