Add CloudFormation Lambda Version Provisioned Concurrency #12594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
approved these changes
May 7, 2025
| invoke_result = aws_client.lambda_.invoke( | ||
| FunctionName=function_name, Qualifier=alias_name, Payload=b"{}" | ||
| ) | ||
| assert "FunctionError" not in invoke_result |
There was a problem hiding this comment.
q: do we still need this assertion of we are snapshotting the result?
There was a problem hiding this comment.
The assertion is not strictly when it comes to AWS<->LS parity. However, we commonly clarify the intention for Lambda invokes (see Lambda test suite) because it's too/so easy to overlook a snapshot update, which contains a failing Lambda response (happened twice here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12592
Motivation
Testing for a support issue revealed an auxiliary issue that provisioned concurrency is not implemented for the CloudFormation resource AWS::Lambda::Version.
Changes
test_lambda_version_provisioned_concurrency. I opted for creating a separate test case for provisioned concurrency to ensure both paths work independently, especially given that provisioned concurrency includes different waiters (takes much longer). Feel free to suggest if combining them would be better.test_lambda_versionto validate actual behavior for provisioned concurrency (fixed in Fix provisioned concurrency set on Lambda alias #12592)