Fix provisioned concurrency set on Lambda alias #12592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe4dev
approved these changes
May 7, 2025
| @@ -156,6 +156,12 @@ def get_invocation_lease( | |||
| provisioned_concurrency_config = function.provisioned_concurrency_configs.get( | |||
| function_version.id.qualifier | |||
| ) | |||
There was a problem hiding this comment.
docs: Would a docstring help to clarify our findings?
# Look up a potential provisioned concurrency config for aliases because a function version shares provisioned concurrency with aliases. However, the config only applies to a single function version or alias on the CRUD level.
There was a problem hiding this comment.
I added some comments on it!
gregfurman
approved these changes
May 7, 2025
localstack-core/localstack/services/lambda_/invocation/counting_service.py
Show resolved
Hide resolved
| @@ -2539,6 +2539,59 @@ def test_provisioned_concurrency(self, create_lambda_function, snapshot, aws_cli | |||
| result2 = json.load(invoke_result2["Payload"]) | |||
| assert result2 == "on-demand" | |||
|
|
|||
| @markers.aws.validated | |||
| def test_provisioned_concurrency_on_alias(self, create_lambda_function, snapshot, aws_client): | |||
There was a problem hiding this comment.
question: Should we be confirming within the test that no additional containers are brought up?
There was a problem hiding this comment.
There will be an additional container brought up for the last invocation, but in general, confirming that we hit the right invocation type environment should be sufficient, otherwise we cannot validate it against AWS as well.
simonrw
pushed a commit
that referenced
this pull request
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when setting provisioned concurrency on a lambda alias pointing to a version, and then invoking it, there will still be another container spawned up on demand.
This happens due to an error in the lookup of the provisioned concurrency config in the counting service, which issues leases for environments.
Changes