Remove legacy StepFunctions v1 provider #11734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, only minor and patch changes are allowed on master. Your PR labels (semver: major) indicate that it cannot be merged into the master at this time. |
a733173 to
5ee2932
Compare
5ee2932 to
8528151
Compare
726af73 to
e03de05
Compare
e03de05 to
89bd89e
Compare
89bd89e to
d99e92c
Compare
dominikschubert
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
LGTM, nice attention to detail with the explicit v2 provider as well. We could even leave this in until 5.0 for a longer phase-out but less code is always nice of course.
It's great that we can now finally remove the fairly hacky v1 provider and SO much complex (and now unused) code 🧹
The artifacts that we're hosting in the artifacts repo need to stay a while longer unfortunately to keep supporting older versions.
d99e92c to
11e79e5
Compare
e629b30 to
9b8d0e1
Compare
dominikschubert
approved these changes
Nov 8, 2024
11e79e5 to
aecea48
Compare
# Conflicts: # localstack-core/localstack/deprecations.py # localstack-core/localstack/services/lambda_/provider.py
aecea48 to
dca3679
Compare
dfangl
pushed a commit
that referenced
this pull request
Nov 14, 2024
dominikschubert
pushed a commit
that referenced
this pull request
Nov 14, 2024
dominikschubert
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on CI job removal #11778
Motivation
The new StepFunctions provider v2 has been the default implementation since LocalStack 3.0.0 and we announced in the blog post that we are planning to remove the legacy v1 implementation with the next major release.
Changes
localstack-core/localstack/services/stepfunctions/legacyincluding the package installers not required anymore 🧹tests/aws/services/stepfunctions/legacyPROVIDER_OVERRIDE_STEPFUNCTIONSTesting
Mostly regression test suite.
Deprecations could be tested manually.
Known Regressions
There are no known regressions and only few tests were executed for the legacy StepFunctions provider (only the legacy tests directory).
These tests had a conditional v2 skip but are likely just new snapshot skips rather than regressions (thanks @MEPalma for the clarification):
aws.services.stepfunctions.v2.scenarios.test_sfn_scenarios.TestFundamental.test_step_functions_calling_api_gatewaypaths=["$..content-type"], # *FIXME: v2 includes extra content-type fields in Header fields.*aws.services.stepfunctions.v2.scenarios.test_sfn_scenarios.TestFundamental.test_wait_for_callbackpaths=["$..MessageId"]TODO
What's left to do: