10000 Remove legacy StepFunctions v1 provider (#11734) · localstack/localstack@3a88754 · GitHub
[go: up one dir, main page]
Skip to content

Commit 3a88754

Browse files
joe4devdominikschubert
joe4dev
authored and
dominikschubert
committed
Remove legacy StepFunctions v1 provider (#11734)
1 parent 0a33539 commit 3a88754

File tree

12 files changed

+9
-1311
lines changed

12 files changed

+9
-1311
lines changed

‎localstack-core/localstack/deprecations.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,12 @@ def is_affected(self) -> bool:
292292
"This option is not supported by the new Lambda Event Source Mapping v2 implementation."
293293
" Please create a GitHub issue if you experience any performance challenges.",
294294
),
295+
EnvVarDeprecation(
296+
"PROVIDER_OVERRIDE_STEPFUNCTIONS",
297+
"4.0.0",
298+
"This option is ignored because the legacy StepFunctions provider (v1) has been removed since 4.0.0."
299+
" Please remove PROVIDER_OVERRIDE_STEPFUNCTIONS.",
300+
),
295301
]
296302

297303

‎localstack-core/localstack/services/lambda_/provider.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import itertools
55
import json
66
import logging
7-
import os
87
import re
98
import threading
109
import time
@@ -226,7 +225,6 @@
226225
)
227226
from localstack.utils.bootstrap import is_api_enabled
228227
from localstack.utils.collections import PaginatedList
229-
from localstack.utils.files import load_file
230228
from localstack.utils.strings import get_random_hex, short_uid, to_bytes, to_str
231229
from localstack.utils.sync import poll_condition
232230
from localstack.utils.urls import localstack_host
@@ -1522,30 +1520,6 @@ def invoke(
15221520
function_name, qualifier = api_utils.get_name_and_qualifier(
15231521
function_name, qualifier, context
15241522
)
1525-
try:
1526-
self._get_function(function_name=function_name, account_id=account_id, region=region)
1527-
except ResourceNotFoundException:
1528-
# remove this block when AWS updates the stepfunctions image to support aws-sdk invocations
1529-
if "localstack-internal-awssdk" in function_name:
1530-
# init aws-sdk stepfunctions task handler
1531-
from localstack.services.stepfunctions.packages import stepfunctions_local_package
1532-
1533-
code = load_file(
1534-
os.path.join(
1535-
stepfunctions_local_package.get_installed_dir(),
1536-
"localstack-internal-awssdk",
1537-
"awssdk.zip",
1538-
),
1539-
mode="rb",
1540-
)
1541-
lambda_client = connect_to().lambda_
1542-
lambda_client.create_function(
1543-
FunctionName="localstack-internal-awssdk",
1544-
Runtime=Runtime.nodejs20_x,
1545-
Handler="index.handler",
1546-
Code={"ZipFile": code},
1547-
Role=f"arn:{get_partition(region)}:iam::{account_id}:role/lambda-test-role", # TODO: proper role
1548-
)
15491523

15501524
time_before = time.perf_counter()
15511525
try:

‎localstack-core/localstack/services/providers.py

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -365,40 +365,16 @@ def stepfunctions():
365365
return Service.for_provider(provider)
366366

367367

368+
# TODO: remove with 4.1.0 to allow smooth deprecation path for users that have v2 set manually
368369
@aws_provider(api="stepfunctions", name="v2")
369370
def stepfunctions_v2():
371+
# provider for people still manually using `v2`
370372
from localstack.services.stepfunctions.provider import StepFunctionsProvider
371373

372374
provider = StepFunctionsProvider()
373375
return Service.for_provider(provider)
374376

375377

376-
@aws_provider(api="stepfunctions", name="v1")
377-
def stepfunctions_legacy():
378-
from localstack.services.stepfunctions.legacy.provider_legacy import StepFunctionsProvider
379-
380-
provider = StepFunctionsProvider()
381-
return Service.for_provider(
382-
provider,
383-
dispatch_table_factory=lambda _provider: HttpFallbackDispatcher(
384-
_provider, _provider.get_forward_url
385-
),
386-
)
387-
388-
389-
@aws_provider(api="stepfunctions", name="legacy")
390-
def stepfunctions_v1():
391-
from localstack.services.stepfunctions.legacy.provider_legacy import StepFunctionsProvider
392-
393-
provider = Step B41A FunctionsProvider()
394-
return Service.for_provider(
395-
provider,
396-
dispatch_table_factory=lambda _provider: HttpFallbackDispatcher(
397-
_provider, _provider.get_forward_url
398-
),
399-
)
400-
401-
402378
@aws_provider()
403379
def swf():
404380
from localstack.services.moto import MotoFallbackDispatcher

‎localstack-core/localstack/services/stepfunctions/legacy/__init__.py

Whitespace-only changes.

‎localstack-core/localstack/services/stepfunctions/legacy/provider_legacy.py

Lines changed: 0 additions & 75 deletions
This file was deleted.

‎localstack-core/localstack/services/stepfunctions/legacy/stepfunctions_starter.py

Lines changed: 0 additions & 154 deletions
This file was deleted.

0 commit comments

Comments
 (0)
0