8000 Remove legacy StepFunctions provider · localstack/localstack@8528151 · GitHub
[go: up one dir, main page]
Skip to content

Commit 8528151

Browse files
joe4devjoe4dev
committed
Remove legacy StepFunctions provider
1 parent efc629f commit 8528151

File tree

12 files changed

+9
-1311
lines changed

12 files changed

+9
-1311
lines changed

‎localstack-core/localstack/deprecations.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,12 @@ def is_affected(self) -> bool:
275275
"This option was confusingly named. Please use DNS_NAME_PATTERNS_TO_RESOLVE_UPSTREAM "
276276
"instead.",
277277
),
278+
EnvVarDeprecation(
279+
"PROVIDER_OVERRIDE_STEPFUNCTIONS",
280+
"4.0.0",
281+
"This option is ignored because the legacy StepFunctions provider (v1) has been removed since 4.0.0."
282+
" Please remove PROVIDER_OVERRIDE_STEPFUNCTIONS.",
283+
),
278284
]
279285

280286

‎localstack-core/localstack/services/lambda_/provider.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import itertools
55
import json
66
import logging
7-
import os
87
import re
98
import threading
109
import time
@@ -230,7 +229,6 @@
230229
)
231230
from localstack.utils.bootstrap import is_api_enabled
232231
from localstack.utils.collections import PaginatedList
233-
from localstack.utils.files import load_file
234232
from localstack.utils.strings import get_random_hex, long_uid, short_uid, to_bytes, to_str
235233
from localstack.utils.sync import poll_condition
236234
from localstack.utils.urls import localstack_host
@@ -1530,30 +1528,6 @@ def invoke(
15301528
function_name, qualifier = api_utils.get_name_and_qualifier(
15311529
function_name, qualifier, context
15321530
)
1533-
try:
1534-
self._get_function(function_name=function_name, account_id=account_id, region=region)
1535-
except ResourceNotFoundException:
1536-
# remove this block when AWS updates the stepfunctions image to support aws-sdk invocations
1537-
if "localstack-internal-awssdk" in function_name:
1538-
# init aws-sdk stepfunctions task handler
1539-
from localstack.services.stepfunctions.packages import stepfunctions_local_package
1540-
1541-
code = load_file(
1542-
os.path.join(
1543-
stepfunctions_local_package.get_installed_dir(),
1544-
"localstack-internal-awssdk",
1545-
"awssdk.zip",
1546-
),
1547-
mode="rb",
1548-
)
1549-
lambda_client = connect_to().lambda_
1550-
lambda_client.create_function(
1551-
FunctionName="localstack-internal-awssdk",
1552-
Runtime=Runtime.nodejs20_x,
1553-
Handler="index.handler",
1554-
Code={"ZipFile": code},
1555-
Role=f"arn:{get_partition(region)}:iam::{account_id}:role/lambda-test-role", # TODO: proper role
1556-
)
15571531

15581532
time_before = time.perf_counter()
15591533
try:

‎localstack-core/localstack/services/providers.py

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -399,40 +399,16 @@ def stepfunctions():
399399
return Service.for_provider(provider)
400400

401401

402+
# TODO: remove with 4.1.0 to allow smooth deprecation path for users that have v2 set manually
402403
@aws_provider(api="stepfunctions", name="v2")
403404
def stepfunctions_v2():
405+
# provider for people still manually using `v2`
404406
from localstack.services.stepfunctions.provider import StepFunctionsProvider
405407

406408
provider = StepFunctionsProvider()
407409
return Service.for_provider(provider)
408410

409411

410-
@aws_provider(api="stepfunctions", name="v1")
411-
def stepfunctions_legacy():
412-
from localstack.services.stepfunctions.legacy.provider_legacy import StepFunctionsProvider
413-
414-
provider = StepFunctionsProvider()
415-
return Service.for_provider(
416-
provider,
417-
dispatch_table_factory=lambda _provider: HttpFallbackDispatcher(
418-
_provider, _provider.get_forward_url
419-
),
420-
)
421-
422-
423-
@aws_provider(api="stepfunctions", name="legacy")
424-
def stepfunctions_v1():
425-
from localstack.services.stepfunctions.legacy.provider_legacy import StepFunctionsProvider
426-
427-
provider = StepFunctionsProvider()
428-
return Service.for_provider(
429-
provider,
430-
dispatch_table_factory=lambda _provider: HttpFallbackDispatcher(
431-
_provider, _provider.get_forward_url
432-
),
433-
)
434-
435-
436412
@aws_provider()
437413
def swf():
438414
from localstack.services.moto import MotoFallbackDispatcher

‎localstack-core/localstack/services/stepfunctions/legacy/__init__.py

Whitespace-only changes.

‎localstack-core/localstack/services/stepfunctions/legacy/provider_legacy.py

Lines changed: 0 additions & 75 deletions
This file was deleted.

‎localstack-core/localstack/services/stepfunctions/legacy/stepfunctions_starter.py

Lines changed: 0 additions & 154 deletions
This file was deleted.

0 commit comments

Comments
 (0)
0