8000 fix opensearch and kinesis test markers by alexrashed · Pull Request #11141 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

fix opensearch and kinesis test markers #11141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2024
Merged

fix opensearch and kinesis test markers #11141

merged 2 commits into from
Jul 5, 2024

Conversation

alexrashed
Copy link
Member

Motivation

While working on #11133, I saw that the test module contains a few tests with "needs fixing".
Also, @bentsku made me aware of the fact that the opensearch test module contains a lot of markers.aws.unkown which we try to get rid of with lots of PRs in the last few months. Just adding a few cross-links to connect these efforts a bit:

Changes

  • Fixes all but one non-AWS validated kinesis test (the last one fails with an Internal S 8000 erver Error / 500 by AWS).
  • Basically marks most of the opensearch tests as needs_fixing (the domain creation fixture is not working against AWS yet), and some as only_localstack (there are a lot of tests for the different endpoint strategies).

@alexrashed alexrashed added aws:kinesis Amazon Kinesis aws:opensearch Amazon OpenSearch Service semver: patch Non-breaking changes which can be included in patch releases labels Jul 4, 2024
@alexrashed alexrashed added this to the 3.6 milestone Jul 4, 2024
@alexrashed alexrashed requested a review from bentsku July 4, 2024 15:34
@alexrashed alexrashed self-assigned this Jul 4, 2024
@alexrashed alexrashed requested a review from silv-io as a code owner July 4, 2024 15:34
@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 4, 2024

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   43m 25s ⏱️ - 51m 58s
884 tests  - 2 286  752 ✅  - 2 023  132 💤  - 263  0 ❌ ±0 
886 runs   - 2 286  752 ✅  - 2 023  134 💤  - 263  0 ❌ ±0 

Results for commit b6588eb. ± Comparison against base commit 655ca21.

This pull request removes 2286 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambda
8000
DestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

bentsku
bentsku approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor
@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for taking care of this, this helps us a lot 🙏 also, nice to see lots of Kinesis tests validated now! Really love the aws_http_client_factory fixture ❤️

@alexrashed alexrashed merged commit 2362204 into master Jul 5, 2024
41 checks passed
@alexrashed alexrashed deleted the fix-tests-with-non-validated-markers branch July 5, 2024 06:28
@alexrashed alexrashed mentioned this pull request Jul 8, 2024
Merged
@alexrashed alexrashed mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku approved these changes

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

Assignees

@alexrashed alexrashed

Labels
aws:kinesis Amazon Kinesis aws:opensearch Amazon OpenSearch Service semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrashed @bentsku
0