8000 Add AWS validation information for es service by silv-io · Pull Request #11206 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

Add AWS validation information for es service #11206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

silv-io
Copy link
Member
@silv-io silv-io commented Jul 15, 2024

Motivation

In an effort to have complete information on which tests are validated to be in parity with AWS the es service is still missing.

Changes

This PR adds that missing information, with one test working on AWS, one test testing specific localstack functionality and the rest not conforming to AWS (because of a discrepancy in the create_domain endpoint).

Note that the entire test suite is still marked as flaky.

@silv-io silv-io added the semver: patch Non-breaking changes which can be included in patch releases label Jul 15, 2024
@silv-io silv-io requested a review from alexrashed as a code owner July 15, 2024 10:29
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! The markers are looking good, thanks for checking! 🚀
Cross-Linking #11141 here to associate to the other marker changes, and pinging @steffyP for visibility. :)

@silv-io silv-io merged commit 4913d52 into master Jul 15, 2024
24 of 31 checks passed
@silv-io silv-io deleted the mark-elasticache-tests branch July 15, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0