8000 Triage aws_unknown markers across AWS test suite by dominikschubert · Pull Request #9141 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Triage aws_unknown markers across AWS test suite #9141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2023
Merged

Triage aws_unknown markers across AWS test suite #9141

merged 3 commits into from
Sep 13, 2023

Conversation

dominikschubert
Copy link
Member

Motivation

To unblock another task (opening a GH issue for all aws_unknown/aws_needs_fixing markers, I need to reduce them first, otherwise we're running into issues with the maximum character limit for GH issues.

Changes

  • Validate a lot of @markers.aws.unknown-marked integration tests against AWS and assigned @markers.aws.validated/@markers.aws.needs_fixing/@markers.aws.only_localstack where applicable.

@dominikschubert dominikschubert self-assigned this Sep 13, 2023
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Sep 13, 8000 2023
@dominikschubert dominikschubert marked this pull request as ready for review September 13, 2023 18:09
steffyP
steffyP approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member
@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow 🚀 amazing to have so many validated tests now 😄

@github-actions
Copy link
github-actions bot commented Sep 13, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 12m 9s ⏱️ -28s
2 203 tests  - 2  1 706 ✔️  - 1  497 💤  - 1  0 ❌ ±0 
2 204 runs   - 2  1 706 ✔️  - 1  498 💤  - 1  0 ❌ ±0 

Results for commit eb6a514. ± Comparison against base commit c35d069.

This pull request removes 2 tests. 
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_import
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_with_template_url
This pull request skips 1 test. 
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_create_existing

♻️ This comment has been updated with latest results.

@coveralls
Copy link

Coverage Status

coverage: 80.113% (-0.01%) from 80.123% when pulling eb6a514 on triage-unknown-markers into c35d069 on master.

@dominikschubert dominikschubert merged commit fa10d1d into master Sep 13, 2023
@dominikschubert dominikschubert deleted the triage-unknown-markers branch September 13, 2023 22:40
@dominikschubert dominikschubert mentioned this pull request Sep 13, 2023
Merged
@baermat baermat mentioned this pull request May 29, 2024
Merged
@alexrashed alexrashed mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffyP steffyP steffyP approved these changes

Assignees

@dominikschubert dominikschubert

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikschubert @coveralls @steffyP
0