refactor: encapsulate prep and bump logic #107
+619
−584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
56cb4d0 to
628ae83
Compare
491b9cd to
0d88be1
Compare
This was referenced Jun 13, 2025
628ae83 to
b5082b8
Compare
0d88be1 to
72d2c26
Compare
48a1e82 to
4f0445e
Compare
4f0445e to
ecc8355
Compare
dylanlott
reviewed
Jun 14, 2025
8000
src/utils.rs
Outdated
|
|
||
| let blob_basefee = prev_header | ||
| .next_block_blob_fee(BlobParams::prague()) | ||
| .expect("signet deployed after 4844 active"); |
There was a problem hiding this comment.
So, this expect was panicking at runtime. I updated it to an unwrap_or and it defaults to the Prague value, but I'm not sure why it was panicking.
dylanlott
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulate logic for the following processes:
So that they are out of the main retrying loop
Closes ENG-1084