10000 fix: make retry attempts respect current slot number by dylanlott · Pull Request #108 · init4tech/builder · GitHub
[go: up one dir, main page]
Skip to content

fix: make retry attempts respect current slot number #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2025
Merged

fix: make retry attempts respect current slot number #108

merged 4 commits into from
Jun 16, 2025

Conversation

dylanlott
Copy link
Contributor
@dylanlott dylanlott commented Jun 13, 2025 •
edited
Loading

fix: make retry attempts respect current slot number

Retry attempts were happening but if the slot changed in the middle of a retry attempt, it wouldn't recognize it and would get into an error loop, exhausting all retry attempts on an obviously incorrect block.

Instead, this PR checks the initial slot number and each retry attempt will only happen if the slot is still valid.

Closes ENG-1127

This was referenced Jun 13, 2025
Merged
Merged
Merged
Closed
@dylanlott Graphite App
Copy link
Contributor Author
dylanlott commented Jun 13, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dylanlott dylanlott mentioned this pull request Jun 13, 2025
Merged
@dylanlott dylanlott added the bug Something isn't working label Jun 14, 2025 — with Graphite App
@dylanlott dylanlott self-assigned this Jun 14, 2025
@dylanlott dylanlott force-pushed the prestwich/bumpable-prep branch from 0d88be1 to 72d2c26 Compare June 14, 2025 00:10
@dylanlott dylanlott force-pushed the dylan/fix-retry-slot-checks branch 3 times, most recently from 449e320 to ff22657 Compare June 14, 2025 00:20
@dylanlott dylanlott force-pushed the prestwich/bumpable-prep branch from 48a1e82 to 4f0445e Compare June 14, 2025 00:21
@dylanlott dylanlott force-pushed the dylan/fix-retry-slot-checks branch from ff22657 to 4bc36fa Compare June 14, 2025 00:22
@dylanlott dylanlott force-pushed the prestwich/bumpable-prep branch from 4f0445e to ecc8355 Compare June 14, 2025 02:35
@dylanlott dylanlott force-pushed the dylan/fix-retry-slot-checks branch 2 times, most recently from 57614e4 to 1e75f23 Compare June 14, 2025 02:36
@dylanlott dylanlott marked this pull request as ready for review June 14, 2025 02:44
@dylanlott dylanlott mentioned this pull request Jun 14, 2025
Merged
@Evalir Evalir changed the base branch from prestwich/bumpable-prep to graphite-base/108 June 16, 2025 14:35
@Evalir Evalir mentioned this pull request Jun 16, 2025
Merged
Evalir
Evalir requested changes Jun 16, 2025
View reviewed changes
@dylanlott dylanlott force-pushed the dylan/fix-retry-slot-checks branch from 1e75f23 to e2ac449 Compare June 16, 2025 16:20
@dylanlott dylanlott force-pushed the graphite-base/108 branch from f6fb01d to dd1fd3f Compare June 16, 2025 16:20
@dylanlott dylanlott changed the base branch from graphite-base/108 to main June 16, 2025 16:20
@dylanlott dylanlott requested a rev 8000 iew from Evalir June 16, 2025 16:42
@Evalir Evalir mentioned this pull request Jun 16, 2025
Merged
Evalir
Evalir approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member
@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a smol nit. feel free to solve and merge

@dylanlott dylanlott merged commit 5300118 into main Jun 16, 2025
6 checks passed
@dylanlott Graphite App
Copy link
Contributor Author

Merge activity

@dylanlott dylanlott deleted the dylan/fix-retry-slot-checks branch June 16, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

Assignees

@dylanlott dylanlott

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanlott @Evalir
0