8000 feat: passes sim result to the submit tasks by dylanlott · Pull Request #100 · init4tech/builder · GitHub
[go: up one dir, main page]
Skip to content

feat: passes sim result to the submit tasks #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: passes sim result to the submit tasks #100

wants to merge 14 commits into from
+278 −216

Conversation

dylanlott
Copy link
Contributor
@dylanlott dylanlott commented Jun 4, 2025 •
edited
Loading

feat: Passes SimResult to the submit task

This PR adds a SimResult type that wraps a BuiltBlock and a BlockEnv together and sends them both to the SubmitTask so that a block's environment is known at submission time for gas calculation purposes.

  • Adds a SimResult type that binds a BlockEnv to a BuiltBlock
  • Passes that SimResult to the SubmitTask for gas calculation purposes
  • Adds some misc. logging and cleanup

Bugfixes

  • Takes cache reference and calculates simulation deadline after the block environment has changed, since that ticks along the loop

Closes ENG-1046

This was referenced Jun 4, 2025
Merged
Merged
@dylanlott Graphite App
Copy link
Contributor Author
dylanlott commented Jun 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dylanlott dylanlott mentioned this pull request Jun 4, 2025
Merged
@dylanlott dylanlott force-pushed the dylan/block-env-refactor branch from 4961bf7 to df3f9a2 Compare June 4, 2025 02:31
@dylanlott dylanlott changed the base branch from dylan/submit-channel-refactors to dylan/add-host-fills June 4, 2025 02:31
@dylanlott dylanlott self-assigned this Jun 4, 2025
@dylanlott dylanlott added the enhancement New feature or request label Jun 4, 2025 — with Graphite App
@dylanlott dylanlott force-pushed the dylan/add-host-fills branch 2 times, most recently from f5c2178 to a873d45 Compare June 4, 2025 17:42
@dylanlott dylanlott force-pushed the dylan/block-env-refactor branch from 95a207e to 9a95da4 Compare June 4, 2025 17:42
@dylanlott dylanlott changed the base branch from dylan/add-host-fills to graphite-base/100 June 4, 2025 17:54
@dylanlott dylanlott force-pushed the graphite-base/100 branch from a873d45 to 1fc9892 Compare June 4, 2025 17:55
@dylanlott dylanlott force-pushed the dylan/block-env-refactor branch from 9a95da4 to c2cd1ab Compare June 4, 2025 17:55
@graphite-app graphite-app bot changed the base branch from graphite-base/100 to main June 4, 2025 17:55
@dylanlott dylanlott force-pushed the dylan/block-env-refactor branch 2 times, most recently from 75b8d71 to 41019b6 Compare June 4, 2025 18:13
@dylanlott dylanlott changed the base branch from main to dylan/chore-deps-sdk-main June 4, 2025 18:13
@dylanlott dylanlott mentioned this pull request Jun 4, 2025
Merged
@dylanlott dylanlott force-pushed the dylan/chore-deps-sdk-main branch from acf2569 to 2234717 Compare June 4, 2025 19:35
@dylanlott dylanlott force-pushed the dylan/block-env-refactor branch 2 times, most recently from 501d86e to 92b1dde Compare June 4, 2025 19:46
@dylanlott dylanlott changed the base branch from dylan/chore-deps-sdk-main to prestwich/simrevert June 4, 2025 19:46
@dylanlott dylanlott force-pushed the prestwich/simrevert branch from 2c09604 to a96a88f Compare June 4, 2025 22:53
@dylanlott dylanlott force-pushed the dylan/block-env-refactor branch from 92b1dde to b69451e Compare June 4, 2025 22:53
@dylanlott dylanlott force-pushed the prestwich/simrevert branch from a96a88f to aee1dd3 Compare June 6, 2025 22:08
@dylanlott dylanlott force-pushed the dylan/block-env-refactor branch from b69451e to 0f48d3e Compare June 6, 2025 22:08
@dylanlott dylanlott force-pushed the prestwich/simrevert branch from aee1dd3 to da4a7fd Compare June 6, 2025 22:10
@dylanlott dylanlott force-pushed the dylan/block-env-refactor branch 2 times, most recently from 3432017 to 6fd3675 Compare June 6, 2025 22:13
This was referenced Jun 12, 2025
Open
Open
@Evalir Evalir changed the base branch from prestwich/simrevert to graphite-base/100 June 13, 2025 10:20
@Evalir Evalir force-pushed the graphite-base/100 branch from 055303d to 1fc9892 Compare June 13, 2025 10:20
@Evalir Evalir changed the base branch from graphite-base/100 to main June 13, 2025 10:20
@Evalir Evalir mentioned this pull request Jun 13, 2025
Open
prestwich
prestwich reviewed Jun 13, 2025
View reviewed changes
prestwich
prestwich reviewed Jun 13, 2025
View reviewed changes
src/tasks/env.rs Outdated
/// The signet block environment, for rollup block simulation.
pub signet: BlockEnv,
/// The host environment header, for host transaction submission pricing.
pub host: Header,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't used by the simulation process, right? It's only used during blob submission to host. So instead of retrieving it here, why not have the blob submission task retrieve it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was that it was a part of the environment, so it made sense to have the EnvTask handle it and update its object, but I can update it to only fetch the Header in the SubmitTask instead.

prestwich
prestwich requested changes Jun 13, 2025
View reviewed changes
Copy link
Member
@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK on passing the header through the stack, header should be retrieved at the place it's needed

@prestwich prestwich force-pushed the dylan/block-env-refactor branch from 44bc5cd to 8dad7d2 Compare June 13, 2025 12:33
This was referenced Jun 13, 2025
Open
Open
@dylanlott dylanlott force-pushed the dylan/block-env-refactor branch from 8dad7d2 to 9f5eaef Compare June 13, 2025 21:17
This was referenced Jun 13, 2025
Open
Open
@dylanlott dylanlott requested a review from prestwich June 14, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Awaiting requested review from Evalir Evalir is a code owner

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@dylanlott dylanlott

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanlott @prestwich
0