feat: passes sim result to the submit tasks #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4961bf7 to
df3f9a2
Compare
f5c2178 to
a873d45
Compare
95a207e to
9a95da4
Compare
a873d45 to
1fc9892
Compare
9a95da4 to
c2cd1ab
Compare
75b8d71 to
41019b6
Compare
acf2569 to
2234717
Compare
501d86e to
92b1dde
Compare
2c09604 to
a96a88f
Compare
92b1dde to
b69451e
Compare
a96a88f to
aee1dd3
Compare
b69451e to
0f48d3e
Compare
aee1dd3 to
da4a7fd
Compare
3432017 to
6fd3675
Compare
- adds a SimResult type that binds a BlockEnv to a BuiltBlock - passess that SimResult to the SubmitTask for gas calculations
54b51a6 to
3e2c5fa
Compare
prestwich
reviewed
Jun 10, 2025
| let mine_time = dispatch_start_time.elapsed().as_secs(); | ||
| let hash = receipt.transaction_hash.to_string(); |
There was a problem hiding this comment.
nit: better not to bind the var. can just inline it on the trace
debug!(
success = receipt.status(),
hash = %receipt.transaction_hash,
mine_time, hash,
"transaction mined"
);
prestwich
reviewed
Jun 10, 2025
| debug!(block_number = ?built_block.block_number(), "finished building block"); | ||
| debug!( | ||
| tx_count = built_block.tx_count(), | ||
| block_number = ?built_block.block_number(), |
There was a problem hiding this comment.
i know this is preserved from earlier, but i think the ? is unnecessary here?
prestwich
reviewed
Jun 10, 2025
|
|
||
| let env = self.construct_block_env(&previous); | ||
| debug!(?env, "constructed block env"); | ||
| debug!(block_number = ?env.number, env.basefee, "constructed latest block env"); |
There was a problem hiding this comment.
thing the ? is unnecessary as number is a number
prestwich
reviewed
Jun 10, 2025
| pub const BASE_MAX_PRIORITY_FEE_PER_GAS: u128 = 2 * GWEI_TO_WEI as u128; | ||
| /// Base maximum fee per blob gas to use as a starting point for retry bumps | ||
| pub const BASE_MAX_FEE_PER_BLOB_GAS: u128 = GWEI_TO_WEI as u128; | ||
| use super::block::sim::SimResult; |
There was a problem hiding this comment.
nit: we tend use to fully qualified crate:: paths instead of super
prestwich
reviewed
Jun 10, 2025
| fn calculate_gas(retry_count: usize, block_env: &BlockEnv) -> (u128, u128, u128) { | ||
| let fallback_blob_basefee = 500; | ||
|
|
||
| match block_env.blob_excess_gas_and_price { |
There was a problem hiding this comment.
the block_env here is the Signet block env, not the host block env, no? it's constructed in EnvTask::construct_block_env and the blob excess gas and price will always be Some(0, 0).
using it to calculate the fee for the host transaction is a bug, as it contains no info about the host
There was a problem hiding this comment.
if you want the host blob gas (which is i think what you're looking for here) you'll need to make the env task's watch channel contain that alongside the constructed BlockEnv by maybe a
struct SimEnv {
signet: BlockEnv,
host: alloy::consensus::Header,
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Passes SimResult to the submit task
Closes ENG-1046
This PR adds a
SimResulttype that wraps aBuiltBlockand aBlockEnvtogether and sends them both to theSubmitTaskso that a block's environment is known at submission time for gas calculation purposes.SimResulttype that binds aBlockEnvto aBuiltBlockSimResultto theSubmitTaskfor gas calculation purposesBugfixes