feat: passes sim result to the submit tasks #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
4961bf7 to
df3f9a2
Compare
f5c2178 to
a873d45
Compare
95a207e to
9a95da4
Compare
a873d45 to
1fc9892
Compare
9a95da4 to
c2cd1ab
Compare
75b8d71 to
41019b6
Compare
acf2569 to
2234717
Compare
501d86e to
92b1dde
Compare
2c09604 to
a96a88f
Compare
92b1dde to
b69451e
Compare
a96a88f to
aee1dd3
Compare
b69451e to
0f48d3e
Compare
aee1dd3 to
da4a7fd
Compare
3432017 to
6fd3675
Compare
prestwich
reviewed
Jun 13, 2025
prestwich
reviewed
Jun 13, 2025
src/tasks/env.rs
Outdated
| /// The signet block environment, for rollup block simulation. | ||
| pub signet: BlockEnv, | ||
| /// The host environment header, for host transaction submission pricing. | ||
| pub host: Header, |
There was a problem hiding this comment.
this isn't used by the simulation process, right? It's only used during blob submission to host. So instead of retrieving it here, why not have the blob submission task retrieve it?
There was a problem hiding this comment.
My thinking was that it was a part of the environment, so it made sense to have the EnvTask handle it and update its object, but I can update it to only fetch the Header in the SubmitTask instead.
prestwich
requested changes
Jun 13, 2025
44bc5cd to
8dad7d2
Compare
This was referenced Jun 13, 2025
- adds a SimResult type that binds a BlockEnv to a BuiltBlock - passess that SimResult to the SubmitTask for gas calculations
8dad7d2 to
9f5eaef
Compare
This was referenced Jun 13, 2025
prestwich
approved these changes
Jun 16, 2025
| .with_gas_limit(30_000); | ||
|
|
||
| // start timer to measure how long it takes to mine the transaction | ||
| let dispatch_start_time: Instant = Instant::now(); | ||
|
|
||
| // dispatch the transaction | ||
| debug!(?tx.nonce, "sending transaction with nonce"); | ||
| let result = provider.send_transaction(tx).await.unwrap(); | ||
|
|
||
| // wait for the transaction to mine |
There was a problem hiding this comment.
isn't this what the metrics task is for? when did we move this out of the metrics task?
| @@ -314,11 +325,11 @@ impl SubmitTask { | |||
| rewardAddress: resp.req.ru_reward_address, | |||
| blockDataHash: *block.contents_hash(), | |||
| }; | |||
| debug!(?header, "built block header"); | |||
| debug!(?header.hostBlockNumber, "built rollup block header"); | |||
A3E2
There was a problem hiding this comment.
logging host block number but message says rollup block header?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Passes SimResult to the submit task
This PR adds a
SimResulttype that wraps aBuiltBlockand aBlockEnvtogether and sends them both to theSubmitTaskso that a block's environment is known at submission time for gas calculation purposes.SimResulttype that binds aBlockEnvto aBuiltBlockSimResultto theSubmitTaskfor gas calculation purposesBugfixes
Closes ENG-1046