Merged
Conversation
release 3.1.0 into develop
Release 3.1.1
* apply fixes from https://gist.github.com/acolomb/945cc5e5b29ced411f1df5b5f9c4a4d0 * simplify find_serial_devices() * fix sphinx warning about indentation
* remove support for Python 3.4 * update testing dependencies * update README.rst
The internal reference for an opened interface via the CANAL API is returned as an integer from the CanalOpen() DLL call in Usb2CanAbstractionLayer.open(). It is supposed to be returned from the abstraction layer and stored in the Usb2canBus.handle member for later reference by all other API calls. Add the missing return statement and adjust the docstring accordingly. Only valid handles (greater than 0) will be returned, otherwise an exception is thrown already.
Before, the config value was not being actually sent to the PEAK hardware due to the setter not being invoked. Instead, the private _state variable was being written to directly. Now, the setter is being invoked and the state is being properly sent to the PEAK hardware.
Originally, the testcase would fail because timestamps would not match. This was due to a Can.Message being initialized had a timestamp value of 0, while a recv'd message had a virtual timestamp. When compared they never matched. Modified testcase now allows for some variation (0.016 s) in the timestamp for a 0.01 s periodic message and compares the last message with the next last message.
Closes #545.
This reverts commit 9669ab5.
Tiny change.
* better developer docs * Add section "About the IO module" * add note about newly added section * Update doc/internal-api.rst
…se class from execution and uses a simple del statement instead
…to test-message-sync
* This fixes the non-standard usage of __test__=False to exclude the base class from execution and uses a simple del statement instead * refactor & comment player * refactor message equality helper * add temporary GC disabeling to test_cycle_time() * add test for MessageSync * exclude AppVeyor from MessageSync tests * make tests/timings easier for CI tests * make tests better suited for CI tests (by excluding them on some platforms)
Various trivial spelling changes throughout the generated docs:
* 'farly' -> 'fairly'
* 'throughly' -> 'thoroughly'
* 'actally' -> 'actually'
* 'tunred' -> 'turned'
* 'seperator' -> 'separator'
* 'busses' -> 'buses'
This would fail in version 4.0 of this library and already prints a warning.
Various spelling corrections in the generated docs
…ly-faster Make coverage collection slightly faster
Fix deprecated constructor call
* Fix stuct packing in build_bcm_header on 32-bit
Previously build_bcm_header relied upon adding a "0q" at the end of the
struct format string in order to force a 8-byte wide alignment on the
struct, in order to interop with the structure defined in the Linux
headers:
struct bcm_msg_head {
__u32 opcode;
__u32 flags;
__u32 count;
struct bcm_timeval ival1, ival2;
canid_t can_id;
__u32 nframes;
struct can_frame frames[0];
};
The Python code assumed that alignof(long long) == 8 bytes in order to
accomplish this. However, on certain 32-bit platforms, this assumption
is not true, and alignof(long long) == 4.
As the struct module does not provide logic to derive alignments of its
types, this changes the packing logic to use ctypes. This exposes the
alignment of the struct members, allowing us to determine whether padding
bytes are necessary.
Fixes #470
* Call BCM factory upon module initialization
In order to prevent the BCM factory method from being called each time a
BCM header struct is created, we create the class when the module gets
created.
* Add SocketCAN interface tests for BCM factory
Add a SocketCAN interface test file with tests for validating the
BcmMsgHead class created by bcm_header_factory on various platforms.
* Clean up comments referencing packing via struct
Clean up the old comment in build_bcm_header referencing the old packing
code that called into Python's struct library. This now uses ctypes, so
and the class is created via the bcm_header_factory factory function, so
we move the comment there instead.
These constants are no longer used in the code and can be cleaned up Fixes #574
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
==========================================
- Coverage 64.58% 63.96% -0.63%
==========================================
Files 63 63
Lines 5647 5708 +61
==========================================
+ Hits 3647 3651 +4
- Misses 2000 2057 +57 |
felixdivo
approved these changes
May 13, 2019
Collaborator
There was a problem hiding this comment.
Thanks for collecting the changelog!
karlding
reviewed
May 15, 2019
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the beta release to final and merges into master.
Try the beta with:
Changelog notes are on the beta release page - https://github.com/hardbyte/python-can/releases/tag/3.2.0-beta.0
All the issues and PRs for this release are closed in the milestone.