E554 Remove support for Python 3.4 + update testing dependencies by felixdivo · Pull Request #532 · hardbyte/python-can · GitHub
[go: up one dir, main page]

Skip to content

Remove support for Python 3.4 + update testing dependencies#532

Merged
hardbyte merged 3 commits intodevelopfrom
remove-python-3.4
Mar 14, 2019
Merged

Remove support for Python 3.4 + update testing dependencies#532
hardbyte merged 3 commits intodevelopfrom
remove-python-3.4

Conversation

@felixdivo
Copy link
Collaborator

This removes support for Python 3.4, since it will reach EOL on 2019-03-16 (=next week).

It also updates the testing tools to their current versions.

@felixdivo felixdivo added the api label Mar 10, 2019
@felixdivo felixdivo added this to the 3.2 Release milestone Mar 10, 2019
@felixdivo felixdivo self-assigned this Mar 10, 2019
@felixdivo felixdivo requested a review from hardbyte March 10, 2019 21:40
@codecov
Copy link
codecov bot commented Mar 10, 2019

Codecov Report

Merging #532 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #532   +/-   ##
========================================
  Coverage    64.46%   64.46%           
========================================
  Files           63       63           
  Lines         5651     5651           
========================================
  Hits          3643     3643           
  Misses        2008     2008

setup.py Outdated
# Installation
# see https://www.python.org/dev/peps/pep-0345/#version-specifiers
python_requires=">=2.7,!=3.0,!=3.1,!=3.2,!=3.3",
python_requires=">=2.7,!=3.0,!=3.1,!=3.2,!=3.3,!=3.4",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean it won't even try to install on Python 3.4? Do we want that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's at least how we did it with Python 3.0-3.3.

Does this mean it won't even try to install on Python 3.4?

And yes, apparently that's how it should be handled.

I guess we don't want that, since it might work and we just don't guarantee it. But then let's remove everything except python_requires=">=2.7", right?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just surprised that no one complained about 3.0 through 3.3 not working! I'd have thought we'd get some issues if we remove support for Python 3.4... but then again people running Python3.4 probably aren't going to be running the latest release of python-can either.

I'm okay with you adding the !=3.4

@felixdivo
Copy link
Collaborator Author

We could have a look at this as well: https://setuptools.readthedocs.io/en/latest/setuptools.html#automatic-script-creation

@hardbyte hardbyte merged commit 15c8016 into develop Mar 14, 2019
@hardbyte hardbyte deleted the remove-python-3.4 branch March 14, 2019 09:06
setup.py Outdated

# Installation
# see https://www.python.org/dev/peps/pep-0345/#version-specifiers
python_requires=">=2.7,!=3.0,!=3.1,!=3.2,!=3.3,!=3.4",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardbyte This commit now removed it ... and is merged into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0