Merged
Conversation
…se class from execution and uses a simple del statement instead
Codecov Report
@@ Coverage Diff @@
## develop #561 +/- ##
==========================================
+ Coverage 63.7% 64.01% +0.3%
==========================================
Files 63 63
Lines 5700 5699 -1
==========================================
+ Hits 3631 3648 +17
+ Misses 2069 2051 -18 |
Collaborator
Author
|
This actually works, it's just AppVeyor being strange. -.- |
hardbyte
approved these changes
May 7, 2019
Owner
There was a problem hiding this comment.
Just a few minor comments that might help long term.
…to test-message-sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #369.
This PR:
can.MessageSync(a small change toComparingMessagesTestCasewas required)test_cycle_time()Will have to check whether these new tests run reliably on the CI server.