C++: Robustify the IR by ensuring that a write side effect never has more than 10 types #15313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more than 10 types.
|
No, wait. That's definitely not how we want to do this. (It causes malformed IR!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, after we merged #12125 we suddenly saw a few (templated) member functions belonging to thousands of (templated) classes.
If a member call belongs to many thousands of classes, the write side effect for the qualifier associated with the call has thousands of types (as the type of the write side effect is computed from the type of the qualifier).
This PR limits the impact of such a problem by requiring the set of types to be less than 10. I've picked the number 10 quite arbitrarily as I've seen 6 projects with types (even before we merged #12125).