8000 C++: Robustify the IR by ensuring that a write side effect never has more than 10 types by MathiasVP · Pull Request #15313 · github/codeql · GitHub
[go: up one dir, main page]
Skip to content

C++: Robustify the IR by ensuring that a write side effect never has more than 10 types #15313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

C++: Robustify the IR by ensuring that a write side effect never has more than 10 types #15313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedCall.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,16 @@ class TranslatedStructorQualif 68EB ierSideEffect extends TranslatedArgumentSideEffect
/** DEPRECATED: Alias for getAst */
deprecated override Locatable getAST() { result = this.getAst() }

final override Type getIndirectionType() { result = call.getTarget().getDeclaringType() }
private Type getIndirectionType0() { result = call.getTarget().getDeclaringType() }

final override Type getIndirectionType() {
result = this.getIndirectionType0() and
// Ideally, each function should only belong to one class, but we've seen
// functions that belong to thousands of declaring classes. That
// causes a problem for later analyses (in particular, the aliased SSA
// analysis).
strictcount(this.getIndirectionType0()) < 10
}

final override string getArgString() { result = "this" }

Expand Down
0