8000 C++: Ensure that only one `Function` exists for every function by jketema · Pull Request #12125 · github/codeql · GitHub
[go: up one dir, main page]
Skip to content

C++: Ensure that only one Function exists for every function #12125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 22, 2023
Merged

C++: Ensure that only one Function exists for every function #12125

merged 3 commits into from
Dec 22, 2023

Conversation

jketema
Copy link
Contributor
@jketema jketema commented Feb 7, 2023 •
edited
Loading

For DCA analysis see the internal issue that links to this PR.

@jketema jketema requested a review from a team as a code owner February 7, 2023 15:29
@jketema jketema marked this pull request as draft February 7, 2023 15:29
@github-actions github-actions bot added the C++ label Feb 7, 2023
@jketema jketema force-pushed the unique-function branch 4 times, most recently from bdb4d3c to 957b9a3 Compare December 21, 2023 11:02
@jketema jketema marked this pull request as ready for review December 22, 2023 12:14
jketema
jketema commented Dec 22, 2023
View reviewed changes
MathiasVP
MathiasVP approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor
@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@jketema jketema merged commit 9c039c4 into github:main Dec 22, 2023
@jketema jketema deleted the unique-function branch December 22, 2023 12:56
@jketema jketema mentioned this pull request Dec 22, 2023
Closed
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Jan 12, 2024
@MathiasVP
Revert "Merge pull request github#12125 from jketema/unique-function"
84d08b0 
This reverts commit 9c039c4, reversing
changes made to ecd2003.
jketema added a commit that referenced this pull request Jan 12, 2024
@jketema
Merge pull request #15304 from MathiasVP/revert-12125
b209ea6 
C++: Revert "Merge pull request #12125 from jketema/unique-function"
This was referenced Jan 12, 2024
Closed
Closed
@jketema jketema mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++ documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @MathiasVP
0